[Laszlo-checkins] r6121 - in openlaszlo/branches/wafflecone/lps/components/incubator/rich-text: . test

[ben@openlaszlo.org]

Author: ben
Date: 2007-08-17 11:30:10 -0700 (Fri, 17 Aug 2007)
New Revision: 6121

Modified:
   openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/richtexteditarea.lzx
   openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/test/formatfontsize.lzx
Log:
Change 20070815-ben-j by ben at slim.local on 2007-08-15 13:36:15 PDT
    in /Users/ben/src/svn/openlaszlo/branches/wafflecone
    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: Fix richtext: font size 18 doesn't do anything

New Features:

Bugs Fixed: LPP-4451: Richedittext: Text size 18 doesn't seem to do anything.

Technical Reviewer: jcrowley 
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

The formatfontsize combo box needs to act as if it's changed, in order
to make sure that we tell the editor to change the font size. The superclass
(lzcombobox) doesn't seem to be setting it's "changed" instance variable 
properly, so for now I'm just forcing changed to true when onselect is called. 
The lzcombobox potential bug is filed as LPP-4506.

Release Notes:

Details:
    

Tests:
http://localhost:8080/wafflecone/lps/components/incubator/rich-text/test/richtexteditarea-driver.lzx?lzr=swf8
Select some text. Change it to size 72. Select some of the text inside that 72-point text. Set it to size 18. The text should now be size 18. 



Modified: openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/richtexteditarea.lzx
===================================================================
--- openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/richtexteditarea.lzx	2007-08-17 17:48:55 UTC (rev 6120)
+++ openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/richtexteditarea.lzx	2007-08-17 18:30:10 UTC (rev 6121)
@@ -389,7 +389,7 @@
             var ssel = this._ssel;
             var esel = this._esel;
 
-            // Debug.write("setFormatAttribute, sel is %d to %d", ssel, esel); 
+            // Debug.write("setFormatAttribute, sel is %d to %d", ssel, esel);             
             this.currentformat[attr] = val;
             this.isHTML = true;
                                     

Modified: openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/test/formatfontsize.lzx
===================================================================
--- openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/test/formatfontsize.lzx	2007-08-17 17:48:55 UTC (rev 6120)
+++ openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/test/formatfontsize.lzx	2007-08-17 18:30:10 UTC (rev 6121)
@@ -20,7 +20,6 @@
 
          the state delays instantiation until the RTE is used. -->
 
-     <state name="fontSizeData">
 
          <dataset name="fontsizes">
 
@@ -40,7 +39,6 @@
 
          </dataset>
 
-     </state>
 
      
 
@@ -84,8 +82,6 @@
 
              super.construct(parent, args);
 
-             fontSizeData.apply();
-
          </method>
 
          
@@ -93,7 +89,7 @@
          <!---  @keywords private -->
 
          <method event="onselect"><![CDATA[
-
+                this.setChanged(true); 
                 //------------------------------------------------------------
 
                 // make sure that we call into editor if this combobox has
@@ -108,8 +104,7 @@
 
                     this.editor.delegateRestoreSelection(); 
 
-                }
-
+                } 
                 ]]>
 
          </method>
@@ -155,7 +150,7 @@
  
 
 <!-- * X_LZ_COPYRIGHT_BEGIN ***************************************************
-* Copyright 2005-2006 Laszlo Systems, Inc.  All Rights Reserved.              *
+* Copyright 2005-2007 Laszlo Systems, Inc.  All Rights Reserved.              *
 * Use is subject to license terms.                                            *
 * X_LZ_COPYRIGHT_END ****************************************************** -->
 <!-- @LZX_VERSION@                                                         -->