History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-4843
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: P0 P0
Assignee: Unassigned
Reporter: Philip Romanik
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

Error parsing arguments to lzc using native Windows

Created: 05/Oct/07 09:55 AM   Updated: 08/Nov/07 02:33 PM
Component/s: Build System
Affects Version/s: RingDing (4.1)
Fix Version/s: Cranberry

Time Tracking:
Not Specified

Environment: native Windows. lzc is running lzc.bat

Severity: Minor
Fixed in Change#: 6,736
Fixed in branch: trunk
Runtime: N/A
Fix in hand: True


 Description  « Hide
From Tucker:

Can you verify one other test:

lzc --runtime=swf8 testfile.lzx

Brendan was having issues passing options with '=' in them to the .bat file.

====

I'm going to fix this issue by quoting each parameter.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Philip Romanik - 05/Oct/07 12:52 PM
Also see: LPP-1636

Change 20071005-Philip-6 by Philip@Philip-DC on 2007-10-05 13:42:37 EDT
     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Pass arguments intact to Windows scripts

New Features:

Bugs Fixed: LPP-4843

Technical Reviewer: ptw
QA Reviewer: hqm
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
Arguments were not being transferred intact to java. The old scripts used %1,%2,... to refer to arguments. However, Windows thinks that
--runtime=swf7 is two argument, "--runtime" and "swf7". The only fix I found is to pass the arguments intact using %*.


Tests:
   lzc,lzdc,lzmc pass arguments the same way. Tested on lzc. From the windows command prompt:

   - lzc --runtime=swf8 testfile.lzx

This command should product a file pbr113.lzr=swf8.swf

   - lzc "--runtime=swf8" testfile.lzx

This should work the same as the first case. This makes sure that people that are already escaping the argument can continue to do so.

Files:
M WEB-INF/lps/server/bin/lzc.bat
M WEB-INF/lps/server/bin/lzdc.bat
M WEB-INF/lps/server/bin/lzmc.bat

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071005-Philip-6.tar

Philip Romanik - 26/Oct/07 12:26 PM
Fixed in wafflecone in r6994.

Mamye Kratt - 08/Nov/07 02:33 PM
See Phil's previous comment.