History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-4737
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: P1 P1
Assignee: Max Carlson
Reporter: Sarah Allen
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

Empty graphic seen when you navigate to the OL app without Flash

Created: 14/Sep/07 12:30 PM   Updated: 25/Oct/07 11:59 AM
Component/s: Browser Integration
Affects Version/s: 4.0.5WaffleCone
Fix Version/s: RingDing (4.1), Cranberry

Time Tracking:
Not Specified

File Attachments: None
Image Attachments:

1. flash-install-experience-1.png
(21 kb)

2. flash-install-experience-2.png
(8 kb)

3. screenshot-1.jpg
(196 kb)

4. screenshot-2.jpg
(236 kb)

Severity: Major
Fixed in Change#: 6,905
Runtime: N/A
Fix in hand: False


 Description  « Hide
STEPS
Navigate to app with a browser that does not have Flash installed.

EXPECTED
Graphic seen which tells the user that Flash will be downloaded.

GOT
Empty graphic seen in the upper left corner of the browser.


 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Mark Davis - 16/Sep/07 12:51 PM
I see the broken graphic when navigating to webtop with FP7 installed or with no flash installed. I'll attach screenshots.

Mark Davis - 16/Sep/07 12:53 PM
This is the "noflash" scenario

Mark Davis - 16/Sep/07 12:53 PM
this has flash 7 installed

Sarah Allen - 16/Sep/07 01:48 PM
I see a smaller missing graphic than what Mark saw, and then when the Flash Player is installed, the app opens in that small area, which makes it totally unusable. See attached flash-install-experience-1.png and flash-install-experience-2.png

Sarah Allen - 16/Sep/07 01:59 PM
oops -- flash-install-experience-2.png is covered by LPP-4734

Max Carlson - 18/Oct/07 01:58 PM
Author: max
Date: 2007-10-18 11:08:08 -0700 (Thu, 18 Oct 2007)
New Revision: 6905

Modified:
   openlaszlo/trunk/
   openlaszlo/trunk/lps/includes/source/flash.js
Log:
Change 20071017-maxcarlson-S by maxcarlson@plastik on 2007-10-17 17:18:46 PDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Merge 'Increase size of installer window when flash installs' from trunk

New Features:

Bugs Fixed: LPP-4737

Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: plastik:~/openlaszlo/trunk-clean maxcarlson$ svnmerge.py merge -b -r 6509 -S ../wafflecone
property 'svnmerge-integrated' set on '.'

U lps/includes/source/flash.js

property 'svnmerge-integrated' set on '.'

>From r6509 - When the flash installer runs, a small window is used (the minimum size poissible). I increased the window width/height to 100% of the browser window. This may not be the right fix long term but it hopefully wafflecone to ship.

Tests: From r6509

1. Remove flash from the browsers: The download link is at the bottom of this pa
ge: http://www.adobe.com/support/flashplayer/downloads.html. For Windows, the ex
ecutable is: http://download.macromedia.com/pub/flashplayer/current/uninstall_fl
ash_player.exe

2. Shutdown all instances of the browser(s). Restart your browser.

3. Navigate to the page you want to run. You should get a message that flash mus
t be installed. Once flash is installed, the window size should be 100% and not
the default value (215x138). If the server has just started running, it may take
 some time before the app begins to run.





Property changes on: openlaszlo/trunk
___________________________________________________________________
Name: svnmerge-integrated
   - /openlaszlo/branches/paperpie:1-6504,6506-6574,6576-6795,6798-6801 /openlaszlo/branches/wafflecone:1-5746,5818-6068,6070-6205,6207-6213,6216-6265,6267-6368,6370-6431,6433-6450,6497,6661 /openlaszlo/trunk:1-3892,3894-3952,3954-4393,4395-4461,4463-4467,4469-4471,4473-5085,5087-5171,5173-5203,5205-5209,5211-5331,5333-5334
   + /openlaszlo/branches/paperpie:1-6504,6506-6574,6576-6795,6798-6801 /openlaszlo/branches/wafflecone:1-5746,5818-6068,6070-6205,6207-6213,6216-6265,6267-6368,6370-6431,6433-6450,6497,6509,6661 /openlaszlo/trunk:1-3892,3894-3952,3954-4393,4395-4461,4463-4467,4469-4471,4473-5085,5087-5171,5173-5203,5205-5209,5211-5331,5333-5334

Modified: openlaszlo/trunk/lps/includes/source/flash.js
===================================================================
--- openlaszlo/trunk/lps/includes/source/flash.js 2007-10-18 18:00:19 UTC (rev 6904)
+++ openlaszlo/trunk/lps/includes/source/flash.js 2007-10-18 18:08:08 UTC (rev 6905)
@@ -1321,11 +1321,11 @@
                 url = url.substring(0, i + 3) + '8' + url.substring(i + 4, url.length);
                 dojo.flash.flash8_version = url;
             }
- var installObj = new dojo.flash.Embed(true);
+ var installObj = new dojo.flash.Embed(true, '100%', '100%');
             installObj.write(8); // write out HTML for Flash 8 version+
         }else if(dojo.flash.info.isVersionOrAbove(6, 0, 65)){ // Express Install
             //dojo.debug("Express install");
- var installObj = new dojo.flash.Embed(false);
+ var installObj = new dojo.flash.Embed(false, '100%', '100%');
             installObj.write(8, true); // write out HTML for Flash 8 version+
             installObj.setVisible(true);
             installObj.center();


_______________________________________________
Laszlo-checkins mailing list
Laszlo-checkins@openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

Amy Muntz - 23/Oct/07 07:04 PM
Moving to Cranberry - per Sarah.

Max Carlson - 25/Oct/07 11:59 AM
Author: max
Date: 2007-10-18 11:08:08 -0700 (Thu, 18 Oct 2007)
New Revision: 6905

Modified:
   openlaszlo/trunk/
   openlaszlo/trunk/lps/includes/source/flash.js
Log:
Change 20071017-maxcarlson-S by maxcarlson@plastik on 2007-10-17 17:18:46 PDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Merge 'Increase size of installer window when flash installs' from trunk

New Features:

Bugs Fixed: LPP-4737

Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: plastik:~/openlaszlo/trunk-clean maxcarlson$ svnmerge.py merge -b -r 6509 -S ../wafflecone
property 'svnmerge-integrated' set on '.'

U lps/includes/source/flash.js

property 'svnmerge-integrated' set on '.'

>From r6509 - When the flash installer runs, a small window is used (the minimum size poissible). I increased the window width/height to 100% of the browser window. This may not be the right fix long term but it hopefully wafflecone to ship.

Tests: From r6509

1. Remove flash from the browsers: The download link is at the bottom of this pa
ge: http://www.adobe.com/support/flashplayer/downloads.html. For Windows, the ex
ecutable is: http://download.macromedia.com/pub/flashplayer/current/uninstall_fl
ash_player.exe

2. Shutdown all instances of the browser(s). Restart your browser.

3. Navigate to the page you want to run. You should get a message that flash mus
t be installed. Once flash is installed, the window size should be 100% and not
the default value (215x138). If the server has just started running, it may take
 some time before the app begins to run.





Property changes on: openlaszlo/trunk
___________________________________________________________________
Name: svnmerge-integrated
   - /openlaszlo/branches/paperpie:1-6504,6506-6574,6576-6795,6798-6801 /openlaszlo/branches/wafflecone:1-5746,5818-6068,6070-6205,6207-6213,6216-6265,6267-6368,6370-6431,6433-6450,6497,6661 /openlaszlo/trunk:1-3892,3894-3952,3954-4393,4395-4461,4463-4467,4469-4471,4473-5085,5087-5171,5173-5203,5205-5209,5211-5331,5333-5334
   + /openlaszlo/branches/paperpie:1-6504,6506-6574,6576-6795,6798-6801 /openlaszlo/branches/wafflecone:1-5746,5818-6068,6070-6205,6207-6213,6216-6265,6267-6368,6370-6431,6433-6450,6497,6509,6661 /openlaszlo/trunk:1-3892,3894-3952,3954-4393,4395-4461,4463-4467,4469-4471,4473-5085,5087-5171,5173-5203,5205-5209,5211-5331,5333-5334

Modified: openlaszlo/trunk/lps/includes/source/flash.js
===================================================================
--- openlaszlo/trunk/lps/includes/source/flash.js 2007-10-18 18:00:19 UTC (rev 6904)
+++ openlaszlo/trunk/lps/includes/source/flash.js 2007-10-18 18:08:08 UTC (rev 6905)
@@ -1321,11 +1321,11 @@
                 url = url.substring(0, i + 3) + '8' + url.substring(i + 4, url.length);
                 dojo.flash.flash8_version = url;
             }
- var installObj = new dojo.flash.Embed(true);
+ var installObj = new dojo.flash.Embed(true, '100%', '100%');
             installObj.write(8); // write out HTML for Flash 8 version+
         }else if(dojo.flash.info.isVersionOrAbove(6, 0, 65)){ // Express Install
             //dojo.debug("Express install");
- var installObj = new dojo.flash.Embed(false);
+ var installObj = new dojo.flash.Embed(false, '100%', '100%');
             installObj.write(8, true); // write out HTML for Flash 8 version+
             installObj.setVisible(true);
             installObj.center();