History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-5415
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: P0 P0
Assignee: Unassigned
Reporter: Lorien Henry-Wilkins
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

Inspector window appears in OL app

Created: 07/Feb/08 11:01 AM   Updated: 04/Mar/08 04:24 PM
Component/s: Components - all
Affects Version/s: Freya
Fix Version/s: RingDing (4.1), Freya

Time Tracking:
Not Specified

Severity: Critical
Fixed in Change#: 7,984
Runtime: N/A
Fix in hand: False


 Description  « Hide
A window labeled "Inspector" appears in the swf in front of the app. It contains some debugish output about the canvas including it's position and dimensions. We haven't changed anything on our end that would cause this window to appear.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
P T Withington - 07/Feb/08 11:20 AM
Can you click on the 'Size Profile' in the bottom of the developer console? This should list all the classes (and sources) that the compiler included, and the 'tag' that caused them to be included. I suspect somewhere you have a tag that is causing:

utils/diagnostic/inspector/inspector.lzx

to be auto-included. This is a result of the fix to LPP-3695. Sarah's comment in that bug:

Sarah Allen - 03/Sep/07 04:52 PM
I don't understand how a typo could result in an auto-include... wouldn't there have to be a class in the components directory for that?

is particularly prescient. :)

If my suspicions are right, you must have a tag that is for a class that is undefined in your app that is now causing the inspector to be included; but I don't understand why you wouldn't have gotten a warning or error for a missing class?

Lorien Henry-Wilkins - 07/Feb/08 03:04 PM
I see this:

library | explanation
----------------------------------------------------------------------------------------------------
utils/diagnostic/inspector/inspector.lzx | reference to <item> tag

P T Withington - 08/Feb/08 05:12 AM
Ha. This is because the inspector component defines a class 'item' and you have (one or more) <dataset>s that internally have <item> tags in them. The compiler is erroneously seeing those dataset items as LZX tags and auto-including the inspector because of it.

The simple fix is to revert part of the fix to LPP-3695 and just not have the inspector in the auto-includes list (as it was not in 4.0).

The correct fix is for the compiler to not look inside datasets when it is looking for tags that should be considered for auto-including.

I will make the simple fix for now, so you are not blocked, but leave this open for a real fix.

P T Withington - 08/Feb/08 05:41 AM
r7983 | ptw | 2008-02-08 08:40:40 -0500 (Fri, 08 Feb 2008) | 19 lines
Changed paths:
   M /openlaszlo/trunk/WEB-INF/lps/misc/lzx-autoincludes.properties

Change 20080208-ptw-G by ptw@dueling-banjos.local on 2008-02-08 08:31:01 EST
    in /Users/ptw/OpenLaszlo/ringding-3
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Make it harder to accidentally include the inspector

Bugs Fixed:
LPP-5415 'Inspector window appears in OL app' (partial)

Technical Reviewer: sallen (pending)
QA Reviewer: lhenrywilkins (pending)

Details:
    Remove all but top-level inspector tag from auto-includes.

Tests:
    Inspection


P T Withington - 08/Feb/08 05:56 AM
Test case. Before the fix, you will see an inspector window, despite you not having mentioned it. After the fix, you will get a compilation error that there is no class for the tag `item`. (There will be warnings in the compilation before the fix, but they are irrelevant.)

<canvas>
  <basetrackgroup />
  <item />
  <text>
    There should not be an inspector window
  </text>
</canvas>


P T Withington - 08/Feb/08 06:02 AM
r7984 | ptw | 2008-02-08 09:00:13 -0500 (Fri, 08 Feb 2008) | 30 lines
Changed paths:
   M /openlaszlo/branches/pagan-deities
   M /openlaszlo/branches/pagan-deities/WEB-INF/lps/misc/lzx-autoincludes.properties

Change 20080208-ptw-u by ptw@dueling-banjos.local on 2008-02-08 08:56:19 EST
    in /Users/ptw/OpenLaszlo/pagan-deities
    for http://svn.openlaszlo.org/openlaszlo/branches/pagan-deities

Summary: Merged revisions 7983 via svnmerge from
http://svn.openlaszlo.org/openlaszlo/trunk

........
  r7983 | ptw | 2008-02-08 08:40:40 -0500 (Fri, 08 Feb 2008) | 19 lines
  
  Change 20080208-ptw-G by ptw@dueling-banjos.local on 2008-02-08 08:31:01 EST
      in /Users/ptw/OpenLaszlo/ringding-3
      for http://svn.openlaszlo.org/openlaszlo/trunk
  
  Summary: Make it harder to accidentally include the inspector
  
  Bugs Fixed:
  LPP-5415 'Inspector window appears in OL app' (partial)
  
  Technical Reviewer: sallen (pending)
  QA Reviewer: lhenrywilkins (pending)
  
  Details:
      Remove all but top-level inspector tag from auto-includes.
  
  Tests:
      Inspection
........


Mamye Kratt - 20/Feb/08 12:23 PM
(pagan-deities build r8066 freya/4.0.10)
Test has the following error in both swf and dhtml, as described in the bug:

5415.lzx:3:11: Could not find class definition for tag `item`

Mamye Kratt - 20/Feb/08 12:24 PM
Need to retest in trunk (ringding).

Mamye Kratt - 04/Mar/08 04:24 PM
(trunk build r8155)
Test has the following error in both swf and dhtml, as described in the bug:

5415.lzx:3:11: Could not find class definition for tag `item`