History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-5393
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: P0 P0
Assignee: Unassigned
Reporter: Lorien Henry-Wilkins
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

SWF doesn't get mousewheel events in Firefox when wmode is transparent

Created: 29/Jan/08 06:34 PM   Updated: 27/Mar/08 08:43 AM
Component/s: Browser Integration
Affects Version/s: Mars, RingDing (4.1)
Fix Version/s: RingDing (4.1), Mars

Time Tracking:
Not Specified

Severity: Minor
Fixed in Change#: 8,240
Runtime: N/A
Fix in hand: False


 Description  « Hide
When I set the wmode to transparent in Firefox the swf doesn't get mousewheel events. When I modify embed-new.js to enable the LzMousewheelKernel, the mechanism works fine. Can we enable this mechanism in Firefox when the wmode is transparent?

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Lorien Henry-Wilkins - 29/Jan/08 06:45 PM
THis is also a problem in Netscape and Opera

Max Carlson - 05/Mar/08 03:16 PM
Testcase is to patch as follows, load /trunk/lps/components/extensions/test/html-swf.jsp and use the mouse wheel.

Index: lps/components/extensions/test/html.lzx
===================================================================
--- lps/components/extensions/test/html.lzx (revision 8180)
+++ lps/components/extensions/test/html.lzx (working copy)
@@ -20,6 +20,11 @@
                 parent.main.setSrc('');
             </handler>
         </button>
+ <text>
+ <handler name="onmousewheeldelta" reference="LzKeys" args="d">
+ this.setText(d);
+ </handler>
+ </text>
         <text name="status" y="3" fontstyle="bold" visible="${parent.main.loading}">Loading...</text>
         <html name="main" heightoffset="-74" widthoffset="-19" xoffset="7" yoffset="50" history="true">
             <handler name="oninit">

Max Carlson - 05/Mar/08 04:41 PM
Author: max
Date: 2008-03-05 16:39:43 -0800 (Wed, 05 Mar 2008)
New Revision: 8186

Modified:
   openlaszlo/trunk/lps/includes/source/embednew.js
Log:
Change 20080305-maxcarlson-0 by maxcarlson@Roboto on 2008-03-05 15:17:23 PST
    in /Users/maxcarlson/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix swf mousewheel support on windows opera and firefox when wmode is transparent

New Features:

Bugs Fixed: LPP-5393 - SWF doesn't get mousewheel events in Firefox when wmode is transparent

Technical Reviewer: promanik
QA Reviewer: lhenrywilkins@laszlosystems.com
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Opera on OS X doesn't support the mousewheel in SWF. This change adds mousewheel events to Windows firefox and opera when wmode is transparent.
    

Tests: See LPP-5393



Modified: openlaszlo/trunk/lps/includes/source/embednew.js
===================================================================
--- openlaszlo/trunk/lps/includes/source/embednew.js 2008-03-05 23:22:05 UTC (rev 8185)
+++ openlaszlo/trunk/lps/includes/source/embednew.js 2008-03-06 00:39:43 UTC (rev 8186)
@@ -133,7 +133,9 @@
 
         dojo.flash.setSwf(swfargs, minimumVersion);
         Lz.__BrowserDetect.init();
- if (Lz.__BrowserDetect.OS == 'Mac') {
+ if (Lz.__BrowserDetect.OS == 'Mac' ||
+ // fix for LPP-5393
+ ( swfargs.wmode == 'transparent' && Lz.__BrowserDetect.OS == 'Windows' && (Lz.__BrowserDetect.isOpera || Lz.__BrowserDetect.isFirefox))) {
             LzMousewheelKernel.setCallback(app, '_sendMouseWheel');
         }
     }


_______________________________________________
Laszlo-checkins mailing list
Laszlo-checkins@openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

Maynard Demmon - 06/Mar/08 06:13 PM
Is this going to be fixed in pagan-deities since that is the branch of openlaszlo we are using for webtop AFAIK.

Sarah Allen - 06/Mar/08 06:29 PM
This needs to be addressed in Mars.

Sarah Allen - 06/Mar/08 06:41 PM
actually, we switched to opaque for Firefox Windows. This doesn't fix it for that case.

Max Carlson - 12/Mar/08 02:01 PM
Author: max
Date: 2008-03-12 13:47:45 -0700 (Wed, 12 Mar 2008)
New Revision: 8237

Modified:
   openlaszlo/trunk/lps/includes/source/embednew.js
Log:
Change 20080312-maxcarlson-i by maxcarlson@Roboto on 2008-03-12 12:34:14 PDT
    in /Users/maxcarlson/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: UPDATED Fix swf mousewheel support on windows opera and firefox when wmode is transparent or opaque

New Features:

Bugs Fixed: LPP-5393 - SWF doesn't get mousewheel events in Firefox when wmode is transparent

Technical Reviewer: promanik
QA Reviewer: lhenrywilkins@laszlosystems.com
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Opera on OS X doesn't support the mousewheel in SWF. This change adds mousewheel events to Windows firefox and opera when wmode is transparent.


Tests: See LPP-5393 testcase, try both wmode 'opaque' and wmode 'transparent'



Modified: openlaszlo/trunk/lps/includes/source/embednew.js
===================================================================
--- openlaszlo/trunk/lps/includes/source/embednew.js 2008-03-12 20:14:29 UTC (rev 8236)
+++ openlaszlo/trunk/lps/includes/source/embednew.js 2008-03-12 20:47:45 UTC (rev 8237)
@@ -135,7 +135,7 @@
         Lz.__BrowserDetect.init();
         if (Lz.__BrowserDetect.OS == 'Mac' ||
             // fix for LPP-5393
- ( swfargs.wmode == 'transparent' && Lz.__BrowserDetect.OS == 'Windows' && (Lz.__BrowserDetect.isOpera || Lz.__BrowserDetect.isFirefox))) {
+ ((swfargs.wmode == 'transparent' || swfargs.wmode == 'opaque') && Lz.__BrowserDetect.OS == 'Windows' && (Lz.__BrowserDetect.isOpera || Lz.__BrowserDetect.isFirefox))) {
             LzMousewheelKernel.setCallback(app, '_sendMouseWheel');
         }
     }


_______________________________________________
Laszlo-checkins mailing list
Laszlo-checkins@openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

Mamye Kratt - 19/Mar/08 09:47 AM
(trunk 4 build r8307)

Ran test/components/perf-button.lzx and test/components/layouttest.lzx successfully in swf and dhtml.

Mamye Kratt - 19/Mar/08 09:47 AM
Need to test in mars.

Mamye Kratt - 19/Mar/08 09:56 AM
Closed wrong bug, reopen.