History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-5325
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: P0 P0
Assignee: Unassigned
Reporter: André Bargull
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

MemoryTracer: changeset 7573 contains some of Tucker's Debug-code

Created: 04/Jan/08 02:43 PM   Updated: 30/Jan/08 03:46 PM
Component/s: Debugger
Affects Version/s: RingDing (4.1)
Fix Version/s: RingDing (4.1)

Time Tracking:
Not Specified

Severity: Blocker
Fixed in Change#: 7,733
Runtime: N/A
Fix in hand: True


 Description  « Hide
LzMemory.lzx@l.211:
---
    if (o == global.NamedNodeMap.prototype) {
      Debug.debug("wasMarked: %s, wasLeaked: %s", wasMarked, wasLeaked);
      Debug.inspect(o);
    }
---

also delete l. 258, simple copy'n paste error
// Annotate why this object is alive

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
P T Withington - 04/Jan/08 03:54 PM
r7733 | ptw | 2008-01-04 18:53:13 -0500 (Fri, 04 Jan 2008) | 18 lines
Changed paths:
   M /openlaszlo/trunk/WEB-INF/lps/lfc/debugger/LzMemory.lzs

Change 20080104-ptw-0 by ptw@dueling-banjos.local on 2008-01-04 18:50:26 EST
    in /Users/ptw/OpenLaszlo/ringding-2
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Remove stray debug code left in LzMemory

Bugs Fixed:
LPP-5325 'MemoryTracer: changeset 7573 contains some of Tucker's Debug-code'

Technical Reviewer: a.bargull@intensis.de (pending)

Details:
    Corrected as suggested by Andre

Tests:
    Inspection


P T Withington - 04/Jan/08 03:54 PM
I appear to have managed to _not_ copy this debug code when I migrated the change to wafflecone!

Thanks André for the sharp eyes.

Mamye Kratt - 30/Jan/08 03:46 PM
(trunk 4 local build r7930)
Code has been removed.