
| Key: |
LPP-5314
|
| Type: |
Bug
|
| Status: |
Closed
|
| Resolution: |
Fixed
|
| Priority: |
P0
|
| Assignee: |
Unassigned
|
| Reporter: |
André Bargull
|
| Votes: |
0
|
| Watchers: |
0
|
|
If you were logged in you would be able to see more operations.
|
|
|
| Severity: |
Minor
|
| Fixed in Change#: |
7,791
|
| Runtime: |
SWF7, SWF8
|
| Fix in hand: |
True
|
|
Current implementation:
[code]
loadobj._dbg_name = function () {
with (this) {
var state = valid?"initialized":"invalid";
// Decode boolean flags into state. Order is important.
if (loading) { state = valid?"loading":"aborting"; }
if (loaded) { state = valid?"loaded":"aborted"; }
if (timedout) { state = "timedout"; }
// TODO: [2005-08-11 ptw] LzURL should be able to
// parse a relative URL
var url = (new LzURL(this.reqobj.url)).file;
if (! url) { url = this.reqobj.url; }
return Debug.formatToString("%s (%s)", url, state);
}
};
[/code]
but it must be:
(note using "this.url" instead of "this.reqobj.url";
additionally removed "with"-block to improve readability)
[code]
loadobj._dbg_name = function () {
var valid = this.valid;
var state = valid ? "initialized" : "invalid";
// Decode boolean flags into state. Order is important.
if (this.loading) { state = (valid ? "loading" : "aborting"); }
if (this.loaded) { state = (valid ? "loaded" : "aborted"); }
if (this.timedout) { state = "timedout"; }
// TODO: [2005-08-11 ptw] LzURL should be able to
// parse a relative URL
var url = (new LzURL(this.url)).file;
if (! url) { url = this.url; }
return Debug.formatToString("%s (%s)", url, state);
};
[/code]
|
|
Description
|
Current implementation:
[code]
loadobj._dbg_name = function () {
with (this) {
var state = valid?"initialized":"invalid";
// Decode boolean flags into state. Order is important.
if (loading) { state = valid?"loading":"aborting"; }
if (loaded) { state = valid?"loaded":"aborted"; }
if (timedout) { state = "timedout"; }
// TODO: [2005-08-11 ptw] LzURL should be able to
// parse a relative URL
var url = (new LzURL(this.reqobj.url)).file;
if (! url) { url = this.reqobj.url; }
return Debug.formatToString("%s (%s)", url, state);
}
};
[/code]
but it must be:
(note using "this.url" instead of "this.reqobj.url";
additionally removed "with"-block to improve readability)
[code]
loadobj._dbg_name = function () {
var valid = this.valid;
var state = valid ? "initialized" : "invalid";
// Decode boolean flags into state. Order is important.
if (this.loading) { state = (valid ? "loading" : "aborting"); }
if (this.loaded) { state = (valid ? "loaded" : "aborted"); }
if (this.timedout) { state = "timedout"; }
// TODO: [2005-08-11 ptw] LzURL should be able to
// parse a relative URL
var url = (new LzURL(this.url)).file;
if (! url) { url = this.url; }
return Debug.formatToString("%s (%s)", url, state);
};
[/code] |
Show » |
|
Changed paths:
M /openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs
Change 20080109-hqm-6 by hqm@DADDY_THNKPAD67 on 2008-01-09 16:00:58 EST
in /cygdrive/c/users/hqm/openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf
for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf
Summary: fix for debugging info from lzloader
New Features:
Bugs Fixed:
LPP-5314Technical Reviewer: andre (pending)
QA Reviewer: ptw
Doc Reviewer:
Documentation:
Release Notes:
Details:
get the url from the correct place when debug string is generated
Tests: