History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-5314
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: P0 P0
Assignee: Unassigned
Reporter: André Bargull
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

"LzLoader#debugLoadObj(..)" does not proberly annotate "loadobj"

Created: 27/Dec/07 03:17 PM   Updated: 30/Jan/08 04:29 PM
Component/s: LFC - Data
Affects Version/s: RingDing (4.1)
Fix Version/s: RingDing (4.1)

Time Tracking:
Not Specified

Severity: Minor
Fixed in Change#: 7,791
Runtime: SWF7, SWF8
Fix in hand: True


 Description  « Hide
Current implementation:

[code]
    loadobj._dbg_name = function () {
        with (this) {
            var state = valid?"initialized":"invalid";
            // Decode boolean flags into state. Order is important.
            if (loading) { state = valid?"loading":"aborting"; }
            if (loaded) { state = valid?"loaded":"aborted"; }
            if (timedout) { state = "timedout"; }
            // TODO: [2005-08-11 ptw] LzURL should be able to
            // parse a relative URL
            var url = (new LzURL(this.reqobj.url)).file;
            if (! url) { url = this.reqobj.url; }
            return Debug.formatToString("%s (%s)", url, state);
        }
    };
[/code]

but it must be:
(note using "this.url" instead of "this.reqobj.url";
additionally removed "with"-block to improve readability)

[code]
    loadobj._dbg_name = function () {
        var valid = this.valid;
        var state = valid ? "initialized" : "invalid";
        // Decode boolean flags into state. Order is important.
        if (this.loading) { state = (valid ? "loading" : "aborting"); }
        if (this.loaded) { state = (valid ? "loaded" : "aborted"); }
        if (this.timedout) { state = "timedout"; }
        // TODO: [2005-08-11 ptw] LzURL should be able to
        // parse a relative URL
        var url = (new LzURL(this.url)).file;
        if (! url) { url = this.url; }
        return Debug.formatToString("%s (%s)", url, state);
    };
[/code]

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Henry Minsky - 09/Jan/08 01:03 PM
r7791 | hqm | 2008-01-09 16:02:32 -0500 (Wed, 09 Jan 2008) | 26 lines
Changed paths:
   M /openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs

Change 20080109-hqm-6 by hqm@DADDY_THNKPAD67 on 2008-01-09 16:00:58 EST
    in /cygdrive/c/users/hqm/openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf
    for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf

Summary: fix for debugging info from lzloader

New Features:

Bugs Fixed: LPP-5314

Technical Reviewer: andre (pending)
QA Reviewer: ptw
Doc Reviewer:

Documentation:

Release Notes:

Details:

get the url from the correct place when debug string is generated


Tests:


Mamye Kratt - 30/Jan/08 04:29 PM
(trunk 4 local build r7930)
Reviewed code change is in WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs.