[#LPP-5298] Generated documentation should not include LFCdhtml.js

OpenLaszlo

Generated documentation should not include LFCdhtml.js

Created: 19/Dec/07 02:18 PM Updated: 19/Dec/07 02:51 PM

Component/s:

Doc Tools

Affects Version/s:

RingDingTools (4.1 Ref Guide + Tools)

Fix Version/s:

RingDingTools (4.1 Ref Guide + Tools)

Time Tracking:

Not Specified

Severity:	Minor
Fixed in Change#:	7,624
Runtime:	N/A
Fix in hand:	False

Description

« Hide

The generated documentation should not include LFCdhtml.js, since currently we only support swf live examples in the documentation.

Eventually, when we start supporting DHTML examples, we should change this to insert whichever LFC is appropriate. But not both at once.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Benjamin Shine - 19/Dec/07 02:51 PM

r7624 | ben | 2007-12-19 14:50:14 -0800 (Wed, 19 Dec 2007) | 33 lines
Changed paths:
   M /openlaszlo/trunk/docs/src/xsl/common-html.xsl

Change 20071219-ben-Q by ben@slim.local on 2007-12-19 14:42:49 PST
    in /Users/ben/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Doc tools improvements -- don't load DHTML lfc, specify history: false

New Features:

Bugs Fixed: ~~LPP-5270~~ $3.startExec is not a function firebug error in embed-compressed.js
    ~~LPP-5298~~ Generated documentation should not include LFCdhtml.js
    ~~LPP-5207~~ change height of example code window from 200 to 400 pixels

Technical Reviewer: none
QA reviewer: liorio

Documentation:
Discussion with Max revealed that we should pass in "history: false" when we call
Lz.swfEmbed( ... ) for a live example, so that we don't irritate the history
mechanism. This makes hundreds of firebug errors go away on every page of the
developer's guide.

Also, it is just not necessary to include LFCdhtml.js when we're not planning to
include any dhtml live examples at this point!

This change also finally makes it so that the default height of embedded examples is
400. I'm not sure why this change does that, but it did, so, rejoice.

Tests:
ant clean developers
visit http://localhost:8080/trunk/docs/developers/color.html note that there are no firebug errors
same with http://localhost:8080/trunk/docs/developers/tutorials/laszlo_basics.html