History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-5226
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: P0 P0
Assignee: Unassigned
Reporter: Philip Romanik
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

component sampler has compile error

Created: 10/Dec/07 09:05 AM   Updated: 23/Jan/08 11:42 AM
Component/s: Compiler
Affects Version/s: RingDing (4.1)
Fix Version/s: RingDing (4.1)

Time Tracking:
Not Specified

Severity: Critical
Runtime: N/A
Fix in hand: False


 Description  « Hide
At r7494, http://localhost:8080/trunk/examples/components/style_example.lzx?lzr=swf7

generates an error:

lz/list.lzx:235:76: Syntax error: the token "internal" was not expected at this position. Was expecting <IDENTIFIER>

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
P T Withington - 10/Dec/07 09:17 AM
Don, we need to figure out if 'internal' has to be a keyword, or if it can be context-sensitive. I know es4 tried to limit the new keywords it introduced. If it is in fact a keyword, this code will just have to be fixed. (Maybe the error message from the compiler could be more helpful).

Donald Anderson - 10/Dec/07 04:03 PM

------------------------------------------------------------------------
r7499 | dda | 2007-12-10 19:01:11 -0500 (Mon, 10 Dec 2007) | 37 lines
Changed paths:
   M /openlaszlo/trunk/WEB-INF/lps/server/sc/src/org/openlaszlo/sc/Parser.jjt

Change 20071210-dda-l by dda@freddie.local on 2007-12-10 16:16:47 EST
    in /Users/dda/laszlo/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Allow certain new keywords to be identifiers

New Features: none

Bugs Fixed: LPP-5226, LPP-5178

Technical Reviewer: ptw
QA Reviewer: hminsky
Doc Reviewer: (pending)

Documentation: none

Release Notes: none

Details:
   New keywords: internal, final, override, dynamic, static can be identifiers.
   Confirmed with SWF9 third party compiler that these are allowed, and also that
   public/private/protected are not allowed (oddly enough).

   Made a common shared function in the grammar to get maximal code sharing.

   This change fixes a problem exposed by the addition of the new keywords.
   We need the keywords to make changes to LFC files that will be shared
   among runtimes.

Tests:
  http://localhost:8080/trunk/examples/components/style_example.lzx
     with SWF7 (the reported test case), also SWF8 and DHTML.
  smokecheck SWF8, DHTML
  Tried some .lzs files mentioned in LPP-5178 to verify that the
     new keywords are still accepted in the appropriate places.


------------------------------------------------------------------------

Mamye Kratt - 23/Jan/08 11:42 AM
(trunk 4 local build r7775)
Fixed.