[#LPP-5189] null setter warning when loading library

OpenLaszlo

null setter warning when loading library

Created: 04/Dec/07 03:07 AM Updated: 09/Jan/08 03:36 PM

Component/s:

Kernel - swf6-8

Affects Version/s:

RingDing (4.1)

Fix Version/s:

RingDing (4.1)

Time Tracking:

Not Specified

Severity:	Minor
Fixed in Change#:	7,775
Runtime:	SWF7, SWF8
Fix in hand:	True

Description

« Hide

You get "null-setter" warning when loading a library.
In OL3.x, LzLibrary was extending LzView, in OL4.x it is only extending LzNode, therefore the following calls in LzLibraryLoader#request are now unnecessary.

Simply need fix, LzLibraryLoader#request(..):
function request( req ) {
    //Debug.write("LzLibraryLoader.request() this.proxied=", this.proxied);
    var o = { libpath: req, url: req , lzt: "lib", proxied: this.proxied};
    super.request( o );
    //this.owner.setAttribute( "framesloadratio" , 0 );//<- no longer needed
    //this.owner.setAttribute( "loadratio" , 0 );//<- no longer needed
}

Reported on the forum: http://forum.openlaszlo.org/showthread.php?t=11198

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

André Bargull - 04/Dec/07 03:08 AM

testcase from forum:

test.lzx
========
<canvas width="800" height="600" debug="true" >
<import href="testimportview.lzx" name="testimportview" stage="defer"/>

<view width="200" height="100" bgcolor="0xff00cc" name="testview" align="center">
<simplelayout axis="y" spacing="3"/>
<button text="load library" onclick="testimportview.load()"/>
</view>
</canvas>

testimportview.lzx
==============
<library>
<view width="100" height="200" bgcolor="yellow"/>
</library>

[ Permlink | « Hide ]

Sandhya - 21/Dec/07 05:54 PM

In which file should i make this change i dint get that

[ Permlink | « Hide ]

André Bargull - 23/Dec/07 11:56 AM

file is "/trunk/WEB-INF/lps/lfc/kernel/swf/LzLibraryLoader.lzs".

[ Permlink | « Hide ]

Henry Minsky - 08/Jan/08 02:25 PM

out for review

[ Permlink | « Hide ]

Henry Minsky - 08/Jan/08 04:15 PM

------------------------------------------------------------------------
r7775 | hqm | 2008-01-08 19:14:09 -0500 (Tue, 08 Jan 2008) | 28 lines
Changed paths:
   M /openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzLibraryLoader.lzs

Change 20080108-hqm-6 by hqm@DADDY_THNKPAD67 on 2008-01-08 17:21:21 EST
    in /cygdrive/c/users/hqm/openlaszlo/trunk/WEB-INF/lps/lfc
    for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc

Summary: fix for null-setter warning in lzloadlibrary

New Features:

Bugs Fixed: ~~LPP-5189~~

Technical Reviewer: andre
QA Reviewer: ptw
Doc Reviewer:

Documentation:

Release Notes:

Details:

remove calls which used to apply to LzLibrary when it subclassed LzView

Tests:

see bug report

[ Permlink | « Hide ]

Mamye Kratt - 09/Jan/08 03:36 PM

(trunk 4 local build t7775)

Testfile loads library without a warning in swf7,swf8 and dhtml.