[#LPP-5173] Change r7406 broke replication of text with local datasets

OpenLaszlo

Change r7406 broke replication of text with local datasets

Created: 30/Nov/07 11:41 AM Updated: 01/Feb/08 10:59 AM

Component/s:

Kernel - swf6-8

Affects Version/s:

RingDing (4.1)

Fix Version/s:

RingDing (4.1)

Time Tracking:

Not Specified

Severity:	Minor
Fixed in Change#:	7,426
Runtime:	N/A
Fix in hand:	False

Description

« Hide

Change r7406 - Bugs related to "destroy" causes the following testcase to hang the player:

<canvas>
    <dataset name="foo">
        <foo>
            <bar/>
            <bar/>
        </foo>
    </dataset>

    <handler name="oninit">
        teststate.apply();
        list.locdata.setData(foo.data);
    </handler>

    <state name="teststate">
        <view name="list">
            <dataset name="locdata"/>
            <view name="list" datapath="local:parent.locdata:/foo/bar">
                <text/>
            </view>
        </view>
    </state>
</canvas>

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Max Carlson - 30/Nov/07 05:23 PM

Author: max
Date: 2007-11-30 17:22:28 -0800 (Fri, 30 Nov 2007)
New Revision: 7426

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzSprite.as
Log:
Change 20071130-maxcarlson-w by maxcarlson@Roboto on 2007-11-30 13:18:21 PST
    in /Users/maxcarlson/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix replication of text with local datasets

New Features:

Bugs Fixed: ~~LPP-5173~~ - Change r7406 broke replication of text with local datasets

Technical Reviewer: bargull
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Apparently, sprites _do_ need recursive destruction in some cases.


Tests: See ~~LPP-5173~~.

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzSprite.as
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzSprite.as 2007-11-30 21:39:24 UTC (rev 7425)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzSprite.as 2007-12-01 01:22:28 UTC (rev 7426)
@@ -915,17 +915,13 @@
   *
   */
LzSprite.prototype.destroy = function(recursive){
- /* This does not work!
- * -> Every subview of this sprite's owner has already removed itself, see LzView#destroy(..).
- * Therefore "this.owner.subviews" will be an empty array at this stage!
- */
- /*if (recursive) {
+ if (recursive) {
         if (this.owner.subviews) {
             for (var i = 0; i < this.owner.subviews.length; i++) {
                 this.owner.subviews[i].sprite.destroy(recursive);
             }
         }
- }*/
+ }

     this.__LZFinishDestroyOnIdle();
}

_______________________________________________
Laszlo-checkins mailing list
Laszlo-checkins@openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

[ Show » ]

Max Carlson - 30/Nov/07 05:23 PM Author: max Date: 2007-11-30 17:22:28 -0800 (Fri, 30 Nov 2007) New Revision: 7426 Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzSprite.as Log: Change 20071130-maxcarlson-w by maxcarlson@Roboto on 2007-11-30 13:18:21 PST in /Users/maxcarlson/openlaszlo/trunk for http://svn.openlaszlo.org/openlaszlo/trunk Summary: Fix replication of text with local datasets New Features: Bugs Fixed: ~~LPP-5173~~ - Change r7406 broke replication of text with local datasets Technical Reviewer: bargull QA Reviewer: promanik Doc Reviewer: (pending) Documentation: Release Notes: Details: Apparently, sprites _do_ need recursive destruction in some cases. Tests: See ~~LPP-5173~~. Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzSprite.as =================================================================== --- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzSprite.as 2007-11-30 21:39:24 UTC (rev 7425) +++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzSprite.as 2007-12-01 01:22:28 UTC (rev 7426) @@ -915,17 +915,13 @@ * */ LzSprite.prototype.destroy = function(recursive){ - /* This does not work! - * -> Every subview of this sprite's owner has already removed itself, see LzView#destroy(..). - * Therefore "this.owner.subviews" will be an empty array at this stage! - */ - /*if (recursive) { + if (recursive) { if (this.owner.subviews) { for (var i = 0; i < this.owner.subviews.length; i++) { this.owner.subviews[i].sprite.destroy(recursive); } } - }*/ + } this.__LZFinishDestroyOnIdle(); } _______________________________________________ Laszlo-checkins mailing list Laszlo-checkins@openlaszlo.org http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

[ Permlink | « Hide ]

Mamye Kratt - 01/Feb/08 10:59 AM

(trunk 4 local build r7937)
Test file ran successfully in swf and dhtml.