Details: Because prototype hacks Array, it's no longer safe to use
for (i in array) {...}.
Arrays must be iterated using the .length property instead.
Tests: Try adding a method to Array.prototype and see where it goes wrong. Alternately, try embedding an OL app on a page that uses prototype.js.
Modified: openlaszlo/trunk/lps/includes/source/embednew.js
===================================================================
--- openlaszlo/trunk/lps/includes/source/embednew.js 2007-11-29 23:01:48 UTC (rev 7418)
+++ openlaszlo/trunk/lps/includes/source/embednew.js 2007-11-30 01:11:21 UTC (rev 7419)
@@ -299,7 +299,7 @@
if (s.indexOf('=') == -1) return;
var p = s.split('&');
var d = {};
- for (i in p) {
+ for (var i = 0; i < p.length; i++) {
var nv = p[i].split('=');
if (nv.length == 1) continue;
var n = nv[0];
Max Carlson - 29/Nov/07 05:37 PM Author: max
Date: 2007-11-29 17:11:21 -0800 (Thu, 29 Nov 2007)
New Revision: 7419
Modified:
openlaszlo/trunk/lps/includes/source/embednew.js
Log:
Change 20071129-maxcarlson-T by maxcarlson@Roboto on 2007-11-29 14:59:25 PST
in /Users/maxcarlson/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix embed-compressed.js to use proper Array iteration
New Features:
Bugs Fixed: LPP-5170 - embed-compressed.js is incompatible with prototype.js/scriptaculous
Technical Reviewer: promanik
QA Reviewer: hminsky
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: Because prototype hacks Array, it's no longer safe to use
for (i in array) {...}.
Arrays must be iterated using the .length property instead.
Tests: Try adding a method to Array.prototype and see where it goes wrong. Alternately, try embedding an OL app on a page that uses prototype.js.
Modified: openlaszlo/trunk/lps/includes/source/embednew.js
===================================================================
--- openlaszlo/trunk/lps/includes/source/embednew.js 2007-11-29 23:01:48 UTC (rev 7418)
+++ openlaszlo/trunk/lps/includes/source/embednew.js 2007-11-30 01:11:21 UTC (rev 7419)
@@ -299,7 +299,7 @@
if (s.indexOf('=') == -1) return;
var p = s.split('&');
var d = {};
- for (i in p) {
+ for (var i = 0; i < p.length; i++) {
var nv = p[i].split('=');
if (nv.length == 1) continue;
var n = nv[0];
_______________________________________________
Laszlo-checkins mailing list
Laszlo-checkins@openlaszlo.orghttp://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
Bug
Resolved
--
embed-compressed.js is incompatible with prototype.js/scriptaculous
Date: 2007-11-29 17:11:21 -0800 (Thu, 29 Nov 2007)
New Revision: 7419
Modified:
openlaszlo/trunk/lps/includes/source/embednew.js
Log:
Change 20071129-maxcarlson-T by maxcarlson@Roboto on 2007-11-29 14:59:25 PST
in /Users/maxcarlson/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix embed-compressed.js to use proper Array iteration
New Features:
Bugs Fixed:
LPP-5170- embed-compressed.js is incompatible with prototype.js/scriptaculousTechnical Reviewer: promanik
QA Reviewer: hminsky
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: Because prototype hacks Array, it's no longer safe to use
for (i in array) {...}.
Arrays must be iterated using the .length property instead.
Tests: Try adding a method to Array.prototype and see where it goes wrong. Alternately, try embedding an OL app on a page that uses prototype.js.
Modified: openlaszlo/trunk/lps/includes/source/embednew.js
===================================================================
--- openlaszlo/trunk/lps/includes/source/embednew.js 2007-11-29 23:01:48 UTC (rev 7418)
+++ openlaszlo/trunk/lps/includes/source/embednew.js 2007-11-30 01:11:21 UTC (rev 7419)
@@ -299,7 +299,7 @@
if (s.indexOf('=') == -1) return;
var p = s.split('&');
var d = {};
- for (i in p) {
+ for (var i = 0; i < p.length; i++) {
var nv = p[i].split('=');
if (nv.length == 1) continue;
var n = nv[0];
_______________________________________________
Laszlo-checkins mailing list
Laszlo-checkins@openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins