[#LPP-4779] Put under debug flag - version info and init timer from LZPIX

OpenLaszlo

Put under debug flag - version info and init timer from LZPIX

Created: 24/Sep/07 10:51 AM Updated: 24/Oct/07 01:33 PM

Component/s:

SA - LZPIX

Affects Version/s:

4.0.5WaffleCone

Fix Version/s:

RingDing, 4.0.6/Jujube

Time Tracking:

Not Specified

Severity:	Major
Fixed in Change#:	6,787
Runtime:	N/A
Fix in hand:	False

Description

« Hide

In the LZPIX application, the version information and init timer need to be put under a debug flag so that they don't appear in the production versions of the app.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Amy Muntz - 24/Sep/07 10:52 AM

Please fix in trunk for RingDing.

[ Permlink | « Hide ]

Henry Minsky - 24/Sep/07 11:15 AM

out for review (hey, we used to have a link in JIRA to put it into a "review" state, didn't we? don't
see that anymore)

[ Permlink | « Hide ]

Henry Minsky - 24/Sep/07 11:16 AM

oh there it is, have to confirm the bug first

[ Permlink | « Hide ]

P T Withington - 24/Sep/07 11:54 AM

See ~~LPP-2898~~. And the following mail thread. Perhaps we should clone this bug to investigate a 'real' fix for ringding?

From: P T Withington <ptw@openlaszlo.org>
Date: Sat, 2 Sep 2006 15:44:58 -0400

On 2006-09-01, at 19:55 EDT, Jim Grandy wrote:

> I think the version display on the front page is going to be a
> blocker; I think the simplest solution is to only show the version
> display for debug builds.

Note also that Max put an inittimer timer in too. Both should be
eliminated from the public version.

The _simplest_ change you can make is to simply remove the two lines:

<inittimer/>
<versioninfo/>

from the pr3 branch of the app.

In the long term, how about only including it if `canvas.lpsrelease
== 'Internal'`? My reasoning: in a Debug build, you can always ask
for this information in the debugger, but if you are testing the non-
debug build, you have no such recourse.

[ Permlink | « Hide ]

Henry Minsky - 01/Oct/07 07:41 AM

Proposed fix

<inittimer visible="${canvas.lpsrelease == 'internal'}"/>
<versioninfo visible="${canvas.lpsrelease == 'internal'}"/>

Hey, I wonder if we should have special form tag which means "only instantiate children
if some condition is met". Sort of like a runtime equivalent of <switch> maybe.

[ Permlink | « Hide ]

Amy Muntz - 10/Oct/07 10:16 AM

This has to be fixed in Jujube imminently - as we are ramping up for the production build and the debug information is displaying (along w/timer information). Clicking from Demos area in Laszlo Explorer at this URL: http://127.0.0.1:8080/lps-4.0.x/demos/lzpix/app-loader.html?lzr=swf7&lzt=html

[ Permlink | « Hide ]

Henry Minsky - 10/Oct/07 12:41 PM

------------------------------------------------------------------------
r6787 | hqm | 2007-10-10 14:11:54 -0400 (Wed, 10 Oct 2007) | 27 lines
Changed paths:
   M /openlaszlo/branches/wafflecone/demos/lzpix/app.lzx
   M /openlaszlo/branches/wafflecone/demos/weather/weather.lzx

Change 20071010-hqm-6 by hqm@IBM-2E06404CB67 on 2007-10-10 14:07:37 EDT
    in /cygdrive/c/users/hqm/openlaszlo/wafflecone
    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: remove inittimer and other diagnostic info from lzpix app, fix weather sizing

New Features:

Bugs Fixed: ~~LPP-4779~~

Technical Reviewer: jcrowley
QA Reviewer: amy
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

Tests:

run weather app, see canvas sized
run lzpix, see no inittimer or version info overlay

[ Permlink | « Hide ]

Mamye Kratt - 24/Oct/07 01:26 PM

(wafflecone build 4.0.6 r6841)

Fixed in 4.0.6 release. Reopen to test ringding (trunk).

[ Permlink | « Hide ]

Mamye Kratt - 24/Oct/07 01:33 PM

(trunk4 build r6893)
Closed in trunk.