History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-4555
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: P0 P0
Assignee: Unassigned
Reporter: Benjamin Shine
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

Components hierarchy browser should link to the right page in the reference

Created: 22/Aug/07 02:32 PM   Updated: 20/Feb/08 12:38 PM
Component/s: Documentation
Affects Version/s: 4.0.5WaffleCone
Fix Version/s: RingDingDoc (4.1 DevGuide), Freya

Time Tracking:
Not Specified

Severity: Minor
Fixed in Change#: 8,042
Fixed in branch: trunk
Runtime: N/A
Fix in hand: False


 Description  « Hide
Explorer -> Components -> Class Hierarchy. Click on one of the nodes in the tree, for example, "basecomponent"
EXPECTED: Open a new page with the reference for basecomponent tag.
ACTUAL: Opens a new page with the table of contents for the entire lzx reference.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Amy Muntz - 28/Sep/07 07:39 AM
Just verified that the links are bad - should be index.html?"lz.basewindow.html" (for example) and the current link only points to basewindow.html. Josh - please clean up in trunk for RingDing.

Josh Crowley - 08/Oct/07 01:49 PM
Approved by Phil. Checkin transcript follows:

(Mamye, can you please run through the components browser and make sure all the links work? I'm sure they do, but Phil was unable to verify. If anything's still broken, just reopen and reassign to me. Thanks!)

--------------------------------

Author: jcrowley
Date: 2007-10-08 13:45:40 -0700 (Mon, 08 Oct 2007)
New Revision: 6760

Modified:
  openlaszlo/trunk/docs/component-browser/common.lzx
  openlaszlo/trunk/docs/component-browser/hierarchyview.lzx
Log:
Change 20071008-jcrowley-W by jcrowley@doctormanhattan.mshome.net on 2007-10-08 13:56:28 EDT
   in /Users/jcrowley/src/svn/openlaszlo/trunk-b
   for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Components hierarchy browser should link to the right page in
       the reference

New Features:

Bugs Fixed: LPP-4555 - Components hierarchy browser should link to the
       right page in the reference

Technical Reviewer: pbr
QA Reviewer: ben
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Fixed the links, many were outdated and the request
       mechanism was kind of broken.

Tests: Run the components hierarchy; note that clicking all the
       links in the modified version takes you to the appropriate
       pages, whereas the links in an unmodified version will
       result in 404 errors or simply taking you to the refguide
       index.



Modified: openlaszlo/trunk/docs/component-browser/common.lzx
===================================================================
--- openlaszlo/trunk/docs/component-browser/common.lzx 2007-10-08 19:37:42 UTC (rev 6759)
+++ openlaszlo/trunk/docs/component-browser/common.lzx 2007-10-08 20:45:40 UTC (rev 6760)
@@ -1,6 +1,6 @@
 <library>

- <attribute name="urlprefix" value="../reference/index.html" type="string" />
+ <attribute name="urlprefix" value="../reference/" type="string" />
    <attribute name="lfccolor" value="0xDFD498" type="number" />
    <attribute name="basecolor" value="0xD1DCF1" type="number" />
    <attribute name="lcicolor" value="0xD5E6D2" type="number" />
@@ -68,7 +68,7 @@
        <attribute name="textselectedcolor" value="0xFFFFFF" type="number" />
        <method event="onclick">
            var file = (this.file != '' ? this.file : this.text + '.html');
- var url = canvas.urlprefix + '?' + file;
+ var url = canvas.urlprefix + file;
            LzBrowser.loadURL('javascript: var wptr = window.open("' + url + '","laszlo-reference","resizable=1,width=1000,height=700,left=0,top=0,screenX=0,screenY=0,menubar,location,status,scrollbars,toolbar,address"); wptr.focus(); void(0);');
        </method>
        <method event="onmouseup">

Modified: openlaszlo/trunk/docs/component-browser/hierarchyview.lzx
===================================================================
--- openlaszlo/trunk/docs/component-browser/hierarchyview.lzx 2007-10-08 19:37:42 UTC (rev 6759)
+++ openlaszlo/trunk/docs/component-browser/hierarchyview.lzx 2007-10-08 20:45:40 UTC (rev 6760)
@@ -63,7 +63,7 @@
                  onmousedown="setAttribute('fgcolor', classroot.style.textselectedcolor)">
                <method event="onclick">
                    var file = (classroot.file != '' ? classroot.file : classroot.text + '.html');
- var url = canvas.urlprefix + '?' + file;
+ var url = canvas.urlprefix + file;
                    LzBrowser.loadURL('javascript: var wptr = window.open("' + url + '","test","resizable=1,width=1000,height=700,left=0,top=0,screenX=0,screenY=0,menubar,location,status,scrollbars,toolbar,address"); wptr.focus(); void(0);');
                </method>
                <method event="onmouseup">
@@ -78,15 +78,15 @@
        <view x="1" y="1" width="${parent.width-2}" clip="true"
              height="${parent.height-2}" bgcolor="white" >
            <scrollbar name="mysc" />
- <linktree x="5" text="node" key="lfc" open="true">
- <linktree text="view" key="lfc" open="true">
- <linktree text="basecomponent" key="base" open="true">
- <linktree text="basevaluecomponent" key="base">
- <linktree text="baseformitem" key="base">
- <linktree text="checkbox" isleaf="true" file="lz-checkbox.html" />
- <linktree text="edittext" isleaf="true" file="lz-edittext.html" />
- <linktree text="basecombobox" key="base">
- <linktree text="combobox" isleaf="true" file="lz-combobox.html" />
+ <linktree x="5" text="node" key="lfc" open="true" file="LzNode.html">
+ <linktree text="view" key="lfc" open="true" file="LzView.html">
+ <linktree text="basecomponent" key="base" open="true" file="lz.basecomponent.html">
+ <linktree text="basevaluecomponent" key="base" file="lz.basevaluecomponent.html">
+ <linktree text="baseformitem" key="base" file="lz.baseformitem.html">
+ <linktree text="checkbox" isleaf="true" file="lz.checkbox.html" />
+ <linktree text="edittext" isleaf="true" file="lz.edittext.html" />
+ <linktree text="basecombobox" key="base" file="lz.basecombobox.html">
+ <linktree text="combobox" isleaf="true" file="lz.combobox.html" />
                                    <linktree text="datepickercombobox" isleaf="true">
                                        <!-- there's no doc for datepickerday -->
                                        <method event="oninit">
@@ -94,37 +94,37 @@
                                        </method>
                                    </linktree>
                                </linktree>
- <linktree text="basedatacombobox" key="base">
- <linktree text="datacombobox" isleaf="true" file="lz-datacombobox.html" />
+ <linktree text="basedatacombobox" key="base" file="lz.basedatacombobox.html">
+ <linktree text="datacombobox" isleaf="true" file="lz.datacombobox.html" />
                                </linktree>
- <linktree text="baselist" key="base">
+ <linktree text="baselist" key="base" file="lz.baselist.html">
                                    <linktree text="radiogroup" isleaf="true"
- file="lz-radiogroup.html" />
- <linktree text="basetabslider" key="base">
- <linktree text="tabslider" isleaf="true" />
+ file="lz.radiogroup.html" />
+ <linktree text="basetabslider" key="base" file="lz.basetabslider.html">
+ <linktree text="tabslider" isleaf="true" file="lz.tabslider.html"/>
                                    </linktree>
- <linktree text="list" file="lz-list.html">
- <linktree text="basefloatinglist" file="lz-basefloatinglist.html">
- <linktree text="floatinglist" file="lz-floatinglist.html"
+ <linktree text="list" file="lz.list.html">
+ <linktree text="basefloatinglist" file="lz.basefloatinglist.html">
+ <linktree text="floatinglist" file="lz.floatinglist.html"
                                                      isleaf="true" />
- <linktree text="plainfloatinglist" file="lz-plainfloatinglist.html"
+ <linktree text="plainfloatinglist" file="lz.plainfloatinglist.html"
                                                      isleaf="true" />
                                    </linktree>
                                    </linktree>
- <linktree text="basetabsbar" key="base">
- <linktree text="tabsbar" file="lz-tabsbar.html"
+ <linktree text="basetabsbar" key="base" file="lz.basetabsbar.html">
+ <linktree text="tabsbar" file="lz.tabsbar.html"
                                                  isleaf="true" key="lci" />
                                    </linktree>
                                </linktree> <!-- baselist -->
                            </linktree>
- <linktree text="baselistitem" key="base">
- <linktree text="radiobutton" isleaf="true" file="lz-radio.html" />
- <linktree text="basetabelement" key="base">
- <linktree text="tabelement" isleaf="true" />
+ <linktree text="baselistitem" key="base" file="lz.baselistitem.html">
+ <linktree text="radiobutton" isleaf="true" file="lz.radiobutton.html" />
+ <linktree text="basetabelement" key="base" file="lz.basetabelement.html">
+ <linktree text="tabelement" isleaf="true" file="lz.tabelement.html"/>
                                </linktree>
- <linktree text="listitem" key="lci" file="lz-listitem.html">
- <linktree text="textlistitem" file="lz-textlistitem.html">
- <linktree text="menuitem" file="lz-menuitem.html"
+ <linktree text="listitem" key="lci" file="lz.listitem.html">
+ <linktree text="textlistitem" file="lz.textlistitem.html">
+ <linktree text="menuitem" file="lz.menuitem.html"
                                                  isleaf="true" />
                                        <linktree text="datepickerlistitem" isleaf="true">
                                            <!-- there's no doc for datepickerday -->
@@ -134,48 +134,48 @@
                                        </linktree>
                                    </linktree>
                                </linktree>
- <linktree text="basetab" key="base">
- <linktree text="tab" file="lz-tab.html"
+ <linktree text="basetab" key="base" file="lz.basetab.html">
+ <linktree text="tab" file="lz.tab.html"
                                              isleaf="true" key="lci" />
                                </linktree>
                            </linktree>
                        </linktree>
- <linktree text="basebutton" key="base">
- <linktree text="button" isleaf="true" file="lz-button.html" />
+ <linktree text="basebutton" key="base" file="lz.basebutton.html">
+ <linktree text="button" isleaf="true" file="lz.button.html" />
                        </linktree>
- <linktree text="basedatepicker" key="base">
- <linktree text="datepicker" isleaf="true" file="lz-datepicker.html" />
+ <linktree text="basedatepicker" key="base" file="lz.basedatepicker.html">
+ <linktree text="datepicker" isleaf="true" file="lz.datepicker.html" />
                        </linktree>
- <linktree text="basetabs" key="base">
- <linktree text="tabs" isleaf="true" file="lz-tabs.html" />
+ <linktree text="basetabs" key="base" file="lz.basetabs.html">
+ <linktree text="tabs" isleaf="true" file="lz.tabs.html" />
                        </linktree>
- <linktree text="basetabpane" key="base">
- <linktree text="tabpane" file="lz-tabpane.html"
+ <linktree text="basetabpane" key="base" file="lz.basetabpane.html">
+ <linktree text="tabpane" file="lz.tabpane.html"
                                      isleaf="true" />
                        </linktree>
- <linktree text="basewindow" key="base">
+ <linktree text="basewindow" key="base" file="lz.basewindow.html">
                            <linktree text="windowpanel" key="lci" isleaf="true"
- file="lz-windowpanel.html">
- <linktree text="window" isleaf="true" file="lz-window.html" />
- <linktree text="modaldialog" file="lz-modaldialog.html">
- <linktree text="alert" isleaf="true" file="lz-alert.html" />
+ file="lz.windowpanel.html">
+ <linktree text="window" isleaf="true" file="lz.window.html" />
+ <linktree text="modaldialog" file="lz.modaldialog.html">
+ <linktree text="alert" isleaf="true" file="lz.alert.html" />
                                </linktree>
                            </linktree>
                        </linktree>
- <linktree text="basescrollbar" key="base">
- <linktree text="scrollbar" isleaf="true" file="lz-scrollbar.html"/>
+ <linktree text="basescrollbar" key="base" file="lz.basescrollbar.html">
+ <linktree text="scrollbar" isleaf="true" file="lz.scrollbar.html"/>
                        </linktree>
- <linktree text="basetree" key="base">
- <linktree text="tree" isleaf="true" file="lz-tree.html"/>
+ <linktree text="basetree" key="base" file="lz.basetree.html">
+ <linktree text="tree" isleaf="true" file="lz.tree.html"/>
                        </linktree>
- <linktree text="menu" file="lz-menu.html" isleaf="true" />
- <linktree text="menubar" file="lz-menubar.html" isleaf="true" />
- <linktree text="menuseparator" file="lz-menuseparator.html" isleaf="true" />
+ <linktree text="menu" file="lz.menu.html" isleaf="true" />
+ <linktree text="menubar" file="lz.menubar.html" isleaf="true" />
+ <linktree text="menuseparator" file="lz.menuseparator.html" isleaf="true" />
                    </linktree> <!-- basecomponent -->
- <linktree text="baseform" key="base" open="true">
- <linktree text="form" isleaf="true" file="lz-form.html" />
+ <linktree text="baseform" key="base" open="true" file="lz.baseform.html">
+ <linktree text="form" isleaf="true" file="lz.form.html" />
                    </linktree>
- <linktree text="basedatepickerday" key="base">
+ <linktree text="basedatepickerday" key="base" file="lz.basedatepickerday.html">
                        <linktree text="datepickerday" isleaf="true">
                            <!-- there's no doc for datepickerday -->
                            <method event="oninit">
@@ -183,7 +183,7 @@
                            </method>
                        </linktree>
                    </linktree>
- <linktree text="basedatepickerweek" key="base">
+ <linktree text="basedatepickerweek" key="base" file="lz.basedatepickerweek.html">
                        <linktree text="datepickerweek" isleaf="true">
                            <!-- there's no doc for datepickerweek -->
                            <method event="oninit">
@@ -192,7 +192,7 @@
                        </linktree>
                    </linktree>
                </linktree> <!-- view -->
- <linktree text="submit" isleaf="true"/>
+ <linktree text="submit" isleaf="true" file="lz.submit.html"/>
            </linktree> <!-- node -->
        </view>
    </class>

Mamye Kratt - 29/Oct/07 11:05 AM
Assign resolved RingDingDoc and RingDingTool bugs to frisco for verifictaion in trunk/RingDing.

Steve O'Sullivan - 12/Nov/07 11:32 AM
All lists closed on start in Wafflecone, r7137, WXP SP 2 IE7.

Steve O'Sullivan - 12/Nov/07 03:10 PM
Sorry, that last was a misplaced comment (wrong bug). This has been reproduced in Wafflecone, r7137, WXP SP 2 IE7 however.

Mamye Kratt - 21/Dec/07 01:54 PM
(trunk 4 build r7457)
Closed, tested by Pounce.

Mamye Kratt - 21/Dec/07 01:54 PM
(trunk 4 build r7457)
Tested by Pounce in
IE6/7
FF2/OSX/XP/Linux
SAF2/3

Amy Muntz - 14/Feb/08 10:27 AM
Lou tested this in ringding and freya. It is not fixed. All the links are broken.

Philip Romanik - 15/Feb/08 06:26 AM
Change 20080214-Philip-2 by Philip@Philip-DC on 2008-02-14 22:11:53 EST
     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix component links in the component hierarchy

New Features:

Bugs Fixed: LPP-4555

Technical Reviewer: (pending)
QA Reviewer: (pending)
Doc Reviewer: lou

Documentation:

Release Notes:

Details:
Josh fixed LPP-4555. Turns out there are other pages when you click 'See Related Components' on the component hierarchy page. This change fixes those pages to point to the "new" locations of the reference pages.

Tests:
Visual inspection. The reference guide doesn't build cleanly on Windows. Also, I found a problem with IE6 rendering so the pages need to be tested in that browser. Let me know if you find any pages that aren't correct. I followed the format that the reference page is named lz.<page>.html. For example, the page for base component is called lz.basecomponent.html.

(For IE6 you only need to check one page. The old javascript code to popup a window generated an error on IE6.)

Once this is fixed in trunk we can merge it to the branches.

Files:
M docs/component-browser/tabsview.lzx
M docs/component-browser/listview.lzx
M docs/component-browser/common.lzx
M docs/component-browser/treeview.lzx
M docs/component-browser/formview.lzx
M docs/component-browser/scrollbarview.lzx
M docs/component-browser/menuview.lzx
M docs/component-browser/windowview.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080214-Philip-2.tar


Philip Romanik - 15/Feb/08 07:08 AM
trunk checkin: r8042.

Moved to pagan-deities. r8043.

Mamye Kratt - 20/Feb/08 12:36 PM
(pagan deities build r8066 freya/4.0.10)
Now opens documentation for the component selected.