[#LPP-4548] LzNode.datapath attribute should be renamed to xpath

OpenLaszlo

LzNode.datapath attribute should be renamed to xpath

Created: 22/Aug/07 07:44 AM Updated: 04/Nov/08 04:22 PM

Component/s:

LFC - Data

Affects Version/s:

4.0.5WaffleCone

Fix Version/s:

MisterDonut (4.2 Final)

Time Tracking:

Not Specified

Severity:	Minor
Runtime:	N/A
Fix in hand:	False

Description

« Hide

LzView.datapath can be either a string or a LzDatapath depending on if it is declared as a view attribute or as an lzx node.

This makes it difficult to grok and debug code that other folks write.

It would be cleaner if 'datapath' refers to the object & 'xpath' refers to an xpath string.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Elliot Winard - 22/Aug/07 07:48 AM

this is a language issue and *not* wafflecone specific

[ Permlink | « Hide ]

Amy Muntz - 07/Sep/07 05:37 AM

When you update this, please also update ~~LPP-4676~~ which is related.

[ Permlink | « Hide ]

Henry Minsky - 07/Sep/07 09:19 AM

is this still true in wafflecone. At one point not so long ago I modified the compiler to preprocess the "datapath" attribute to be equivalent at runtime to the <datapath> child element.

[ Permlink | « Hide ]

Henry Minsky - 07/Sep/07 09:36 PM

Oh I think I misread the bug report a little. Yes, it is confusing that we call it
"datapath" as an attribute and <datapath xpath="..."/> when specified as a
datapath child element.

We could add "xpath" as an alternate
attribute name, and then deprecate the "datapath" attribute. We need to make
a proposal and get community input on this.

[ Permlink | « Hide ]

Henry Minsky - 07/Sep/07 09:38 PM

For reference, the code examples for this bug are

[A]
  <view datapath="mydata:/foo/bar"/>

vs the equivalent

[B]
  <view>
    <datapath xpath="mydata:/foo/bar"/>
  </view>

And the proposal is we make [A] be
<view xpath="mydata:/foo/bar" />

[ Permlink | « Hide ]

Amy Muntz - 10/Sep/07 10:52 AM

This is a proposal for an API change. A proposal needs to be submitted to officially start the process. You can place the proposal here: http://wiki.openlaszlo.org/Enhancement_Proposals#Draft_Proposals (and send it to laszlo-dev). Thanks!