[#LPP-4168] onframe event not being sent

OpenLaszlo

onframe event not being sent

Created: 19/Jun/07 06:38 PM Updated: 27/Sep/07 08:55 AM

Component/s:

Kernel - swf6-8

Affects Version/s:

Legals

Fix Version/s:

RingDing (4.1)

Time Tracking:

Not Specified

Severity:	Minor
Fixed in Change#:	5,472
Fixed in branch:	branches/legals
Runtime:	N/A
Fix in hand:	True

Description

« Hide

This testcase should show onframes events until the music stops playing. Failing under firefox 2.0.0.4 on windows
<canvas title="loadperc test" proxied="false" width="100%" height="100%" debug="true">

   <view name="audio">

       <handler name="oninit">
           setSource("http://www.addictech.com/album_mp3s/Skeetaz-Skeeters-Spacebar_Sentiments-SBS007-0001.mp3");
           Debug.write("setSource called");
       </handler>

       <handler name="onloadperc" args="l">
          Debug.write("loadperc: ",l);
       </handler>
       <handler name="onframe" args="l">
          Debug.write("frame: ",l);
       </handler>

       <handler name="onframesloadratio" args="l">
          Debug.write("framesloadratio: ",l);
       </handler>

       <handler name="onloadratio" args="l">
          Debug.write("loadratio: ",l);
       </handler>

       <handler name="onload">
           Debug.write("onload called");
       </handler>

   </view>

</canvas>

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Max Carlson - 19/Jun/07 08:05 PM

Author: max
Date: 2007-06-19 20:04:43 -0700 (Tue, 19 Jun 2007)
New Revision: 5472

Modified:
   openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/swf/LzSprite.as
Log:
Change 20070619-maxcarlson-p by maxcarlson@plastik on 2007-06-19 18:52:10 PDT
    in /Users/maxcarlson/openlaszlo/legals-clean/WEB-INF/lps/lfc
    for http://svn.openlaszlo.org/openlaszlo/branches/legals/WEB-INF/lps/lfc

Summary: Fix onframe events for non-proxied mp3 audio

New Features:

Bugs Fixed: ~~LPP-4168~~ - onframe event not being sent

Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzSprite.as was dereferencing the wrong thing - doe!

Tests: See ~~LPP-4168~~

Files:
M kernel/swf/LzSprite.as

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070619-maxcarlson-p.tar

Modified: openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/swf/LzSprite.as
===================================================================
--- openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/swf/LzSprite.as 2007-06-20 01:56:18 UTC (rev 5471)
+++ openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/swf/LzSprite.as 2007-06-20 03:04:43 UTC (rev 5472)
@@ -1340,7 +1340,7 @@
     this.__lzskipplaycheck = 0;
     this.__lzskipplaychecklimit = 4;
     // skip more frames for mp3 audio resources to allow tracking to work correctly
- if (('isaudio' in this.getMCRef()) && (this.getMCRef().isaudio == true)) this.__lzskipplaychecklimit = __lzskipplaychecklimitmax;
+ if (('isaudio' in this.getMCRef()) && (this.getMCRef().isaudio == true)) this.__lzskipplaychecklimit = LzSprite.prototype.__lzskipplaychecklimitmax;

     //Debug.warn('checkPlayStatus %w %w %w %w', this.__lzcheckframe, this.frame, this.totalframes, this.__lzskipplaychecklimit);
     LzIdle.callOnIdle( this.checkPlayStatusDel );

_______________________________________________
Laszlo-checkins mailing list
Laszlo-checkins@openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

[ Show » ]

Max Carlson - 19/Jun/07 08:05 PM Author: max Date: 2007-06-19 20:04:43 -0700 (Tue, 19 Jun 2007) New Revision: 5472 Modified: openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/swf/LzSprite.as Log: Change 20070619-maxcarlson-p by maxcarlson@plastik on 2007-06-19 18:52:10 PDT in /Users/maxcarlson/openlaszlo/legals-clean/WEB-INF/lps/lfc for http://svn.openlaszlo.org/openlaszlo/branches/legals/WEB-INF/lps/lfc Summary: Fix onframe events for non-proxied mp3 audio New Features: Bugs Fixed: ~~LPP-4168~~ - onframe event not being sent Technical Reviewer: promanik QA Reviewer: jcrowley Doc Reviewer: (pending) Documentation: Release Notes: Details: LzSprite.as was dereferencing the wrong thing - doe! Tests: See ~~LPP-4168~~ Files: M kernel/swf/LzSprite.as Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070619-maxcarlson-p.tar Modified: openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/swf/LzSprite.as =================================================================== --- openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/swf/LzSprite.as 2007-06-20 01:56:18 UTC (rev 5471) +++ openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/swf/LzSprite.as 2007-06-20 03:04:43 UTC (rev 5472) @@ -1340,7 +1340,7 @@ this.__lzskipplaycheck = 0; this.__lzskipplaychecklimit = 4; // skip more frames for mp3 audio resources to allow tracking to work correctly - if (('isaudio' in this.getMCRef()) && (this.getMCRef().isaudio == true)) this.__lzskipplaychecklimit = __lzskipplaychecklimitmax; + if (('isaudio' in this.getMCRef()) && (this.getMCRef().isaudio == true)) this.__lzskipplaychecklimit = LzSprite.prototype.__lzskipplaychecklimitmax; //Debug.warn('checkPlayStatus %w %w %w %w', this.__lzcheckframe, this.frame, this.totalframes, this.__lzskipplaychecklimit); LzIdle.callOnIdle( this.checkPlayStatusDel ); _______________________________________________ Laszlo-checkins mailing list Laszlo-checkins@openlaszlo.org http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

[ Permlink | « Hide ]

Mamye Kratt - 27/Jun/07 04:24 PM

Closing for 4.0.3, will reopen to check in legals

(4.0 branch (4.0.3) build r5531 - linux-builder)
ant lztest

(4.0 branch (4.0.3) build r5522 - XP installer)
testfile in bug

(4.0 branch (4.0.3) local build r5538)
quick check of amazon and lzpix

(4.0 branch (4.0.3) local build r5538)
alldata.lzx

(legals build r5532 - linux-builder)
ant lztest

[ Permlink | « Hide ]

Mamye Kratt - 27/Jun/07 04:26 PM

Reopen to test in legals:
run
-testfile in bug
-quick check of lzpix and amazon
-alldata in swf and dhtml

[ Permlink | « Hide ]

Mamye Kratt - 27/Jun/07 04:44 PM

Misread bug, only need to run testfile for this one

[ Permlink | « Hide ]

Mamye Kratt - 17/Jul/07 11:39 AM

Close to test in legals.