History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-4119
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: -- --
Assignee: Mamye Kratt
Reporter: Max Carlson
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

multiline edittext does not work in IE DHTML

Created: 11/Jun/07 01:30 PM   Updated: 27/Sep/07 08:55 AM
Component/s: Kernel - DHTML
Affects Version/s: Legals
Fix Version/s: RingDing (4.1)

Time Tracking:
Not Specified

Severity: Minor
Fixed in Change#: 5,370
Runtime: N/A
Fix in hand: False


 Description  « Hide
Confirmed in IE 6 and 7.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Max Carlson - 11/Jun/07 01:36 PM
From http://forum.openlaszlo.org/showthread.php?t=9488

Hi all,
i have a problem with edittext on IE 7 (works on Firefox).
I am currently using r5314 (of June 4th).

Code:

<?xml version="1.0" encoding="UTF-8"?> <canvas height="550" bgcolor="silver"> <simplelayout axis="y" spacing="5"/> <edittext height="200" width="300" multiline="true">Test 1.. 2.. 3..</edittext> </canvas>

The edittext control (white area) covers the correct height but the scrollable/editable area is only about two lines high. The content is also only shown in that two-line high area.

Is this a known error? if yes->Is there a workaround?

Do i have to step back to a previous version?

Thank you for any answers.
Reply With Quote

Max Carlson - 11/Jun/07 03:03 PM
Author: max
Date: 2007-06-11 15:00:38 -0700 (Mon, 11 Jun 2007)
New Revision: 5370

Modified:
   openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
   openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
Log:
Change 20070611-maxcarlson-I by maxcarlson@plastik on 2007-06-11 13:30:47 PDT
    in /Users/maxcarlson/openlaszlo/legals-clean
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Fix multiline inputtext height in IE DHTML

New Features:

Bugs Fixed: LPP-4119 - multiline edittext does not work in IE DHTML

Technical Reviewer: promanik
QA Reviewer: hminsky
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzSprite.js - add set_height_for_multiline_inputtext quirk, and turn on for IE - height: 100% css is not working.

LzInputTextSprite.js - setText() directly sets the height of the inputtext div if set_height_for_multiline_inputtext is true.
    

Tests: See LPP-4119 for testcase. Fixes issue in IE 6 and 7 DHTML.



Modified: openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
===================================================================
--- openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js 2007-06-11 21:58:19 UTC (rev 5369)
+++ openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js 2007-06-11 22:00:38 UTC (rev 5370)
@@ -309,6 +309,9 @@
         var h = this.CSSDimension(this.height);
         this.__LZclickdiv.style.height = h;
         this.__LZinputclickdiv.style.height = h;
+ if (this.multiline && this.quirks.set_height_for_multiline_inputtext) {
+ this.__LzInputDiv.style.height = this.CSSDimension(this.height - (this.____hpadding * 2));
+ }
     }
 }
 

Modified: openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
===================================================================
--- openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js 2007-06-11 21:58:19 UTC (rev 5369)
+++ openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js 2007-06-11 22:00:38 UTC (rev 5370)
@@ -205,6 +205,7 @@
     ,canvas_div_cannot_be_clipped: false
     ,inputtext_parents_cannot_contain_clip: false
     ,minimize_opacity_changes: false
+ ,set_height_for_multiline_inputtext: false
 }
 
 LzSprite.prototype.capabilities = {
@@ -250,6 +251,9 @@
 
         // flag for components (basefocusview for now) to minimize opacity changes
         LzSprite.prototype.quirks['minimize_opacity_changes'] = true;
+
+ // multiline inputtext height must be set directly - height: 100% does not work. See LPP-4119
+ LzSprite.prototype.quirks['set_height_for_multiline_inputtext'] = true;
     } else if (Lz.__BrowserDetect.isSafari) {
         // Fix bug in where if any parent of an image is hidden the size is 0
         // TODO: Tucker claims this is fixed in the latest version of webkit


_______________________________________________
Laszlo-checkins mailing list
Laszlo-checkins@openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

Mamye Kratt - 28/Jun/07 05:58 PM
(4.0 branch (4.0.3) local build r5544)
Can enter multiline text now.

Mamye Kratt - 28/Jun/07 05:58 PM
Needs to be tested in legals.

Mamye Kratt - 17/Jul/07 11:54 AM
Need to test in legals.