[#LPP-4102] Sizing canvas height or width to 100 percent isn't working

OpenLaszlo

Sizing canvas height or width to 100 percent isn't working

Created: 06/Jun/07 11:11 AM Updated: 23/Jan/08 04:13 PM

Component/s:

Compiler - JavaScript

Affects Version/s:

Legals

Fix Version/s:

RingDing (4.1)

Time Tracking:

Not Specified

Environment:

legals r5327

Severity:	Minor
Fixed in Change#:	5,423
Runtime:	N/A
Fix in hand:	False

Description

« Hide

<canvas width="100%" height="100%"> is making a canvas about 50 percent.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Max Carlson - 11/Jun/07 11:11 AM

Confirmed on firefox with lzt=html, e.g. http://localhost:8080/legals-clean/my-apps/canvasresize.lzx?lzr=dhtml&lzt=html

[ Permlink | « Hide ]

Max Carlson - 11/Jun/07 11:45 AM

This happened as part of change 5252. Assigning to ptw, as this is his. This change appears to cause fallout with views and sizing in general, including the canvas and roundrectbutton.

[ Permlink | « Hide ]

Mamye Kratt - 12/Jun/07 12:07 PM

Adding comments for Robert Yeager:

In nightly build 5388, this simple test always returns the same width and height of 500x400, regardless of the browser window size, in both SWF/DHTML for IE7/FF:

<canvas id="maincanvas" width="100%" height="100%" validate="false" debug="true" proxied="false" bgcolor="0x00aaaa">
    <debug x="650" y="200" width="800" height="400" fontsize="12"/>

    <handler name="oninit">
        Debug.write(maincanvas.width);
        Debug.write(maincanvas.height);
    </handler>
</canvas>

I am running the test like this: http://localhost:8080/test.lzx?lzr=swf8&debug=true

This was working in 4.0.2.

--
Robert Yeager
Founder, Qrowd
http://www.qrowd.com/blog

[ Permlink | « Hide ]

P T Withington - 14/Jun/07 12:02 PM

I've tracked this down to something introducing an additional level of quotes around the size attribute which is causing it to not be recognized as a percentage.

[ Permlink | « Hide ]

P T Withington - 14/Jun/07 07:18 PM

r5423 | ptw | 2007-06-14 22:17:36 -0400 (Thu, 14 Jun 2007) | 20 lines
Changed paths:
   M /openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java

Change 20070614-ptw-J by ptw@dueling-banjos.local on 2007-06-14 15:59:01 EDT
    in /Users/ptw/OpenLaszlo/legals/test
    for http://svn.openlaszlo.org/openlaszlo/branches/legals/test

Summary: Make canvas percentage dimensions work again

Bugs Fixed:
~~LPP-4012~~ 'Sizing canvas height or width to 100 percent isn't working'

Technical Reviewer: max (Message-ID: <4671BF29.1000307@openlaszlo.org>)
QA Reviewer: support@qrowd.com (pending)
Doc Reviewer: (pending)

Details:
    Revert erroneous optimization from r5252

Tests:
    ant lztest, test case from bug

[ Permlink | « Hide ]

Mamye Kratt - 03/Jul/07 12:49 PM

(4.0 branch (4.0.3) local build r5585)
testfile in bug runs successfully

(4.0 branch (4.0.3) nightly r5581)
ran ant lztest successfully

[ Permlink | « Hide ]

Mamye Kratt - 03/Jul/07 12:50 PM

Need to test in legals.

[ Permlink | « Hide ]

Mamye Kratt - 17/Jul/07 11:58 AM

Need to test in legals.

[ Permlink | « Hide ]

Mamye Kratt - 23/Jan/08 04:13 PM

(trunk 4 local build r7775)
test file runs successfully in swf and dhtml

(trunk 4 build r7833)
lztest succeeded on this build