History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-3998
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: -- --
Assignee: Mamye Kratt
Reporter: Benjamin Shine
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

test-basetabs.lzx reference to undefined variable goldstyle

Created: 18/May/07 01:03 PM   Updated: 03/Jun/08 04:12 PM
Component/s: Components - base
Affects Version/s: Legals
Fix Version/s: RingDing (4.1)

Time Tracking:
Not Specified

Severity: Minor
Fixed in Change#: 9,448
Fixed in branch: trunk
Runtime: N/A
Fix in hand: False


 Description  « Hide
in http://localhost:8080/legals/test/components/lz/test-basetabs.lzx
reference to undefined variable goldstyle
from this line:
    <attribute name="defaultstyle" value="${goldstyle}"/>

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Josh Crowley - 04/Jun/07 06:12 PM
Approved by Ben.

Mamye Kratt - 28/Jun/07 11:02 AM
(4.0 branch (4.0.3) local build r5538)
Getting warnings and errors while running http://127.0.0.1:8080/4.0/test/components/lz/test-basetabs.lzx

SWF7
ERROR: test-basetabs.lzx:329: reference to undefined variable 'visible'
ERROR: test-basetabs.lzx:320: reference to undefined variable 'visible'
WARNING: `menu` is already defined. Use `lz.menu` instead.
WARNING: base/basetabs.lzx:320: reference to undefined property 'visibility'

DHTML
WARNING: test-basetabs.lzx:320: ReferenceError: visible is not defined
WARNING: test-basetabs.lzx:329: ReferenceError: visible is not defined
WARNING: `window` is already defined. Use `lz.window` instead.
WARNING: `alert` is already defined. Use `lz.alert` instead.
WARNING: `menubar` is already defined. Use `lz.menubar` instead.

Josh Crowley - 28/Jun/07 07:57 PM
I don't get these in a current legals build. This must just be an issue specific to 4.0.3. Merge dependency issues, maybe? The only one I get is "lz.menu", and I think that's LPP-3401.

Benjamin Shine - 28/Jun/07 10:37 PM
Hmm, these new errors reported by Mamye in 5538 are a new, separate bug.

Josh Crowley - 05/Jul/07 12:06 AM
So should I re-close this one? I think this was an issue specific to merge problems in 4.0.3, from what I could tell.

Josh Crowley - 15/Aug/07 11:43 AM
Approved by Max.

Mamye Kratt - 02/Jun/08 03:53 PM
(trunk 4 build r9433)

Getting the following error still:

WARNING @base/basecomponent.lzx#354: reference to undefined property 'isdefault'
ERROR: reference to undefined variable 'goldstyle'

Josh Crowley - 03/Jun/08 04:12 PM
Approved by Andre and Max. Checkin transcript follows:

------------------------------------------------------------------------
r9448 | jcrowley | 2008-06-03 19:10:17 -0400 (Tue, 03 Jun 2008) | 28 lines
Changed paths:
   M /openlaszlo/trunk/lps/components/base/basecomponent.lzx
   M /openlaszlo/trunk/test/components/lz/test-basetabs.lzx

Change 20080603-laszlo-2 by laszlo@T43-L3XEXMW on 2008-06-03 05:48:36 EDT
    in /home/laszlo/src/svn/openlaszlo/trunk-3
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: test-basetabs.lzx reference to undefined variable goldstyle

New Features:

Bugs Fixed: LPP-3998 - test-basetabs.lzx reference to undefined variable goldsty
le

Technical Reviewer: max@openlaszlo.org
QA Reviewer: a.bargull@intensis.de
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Fixed the warning and the error that were showing up in
    the Debugger when running the test file. (One was a needless
    reference to a style class; the other was a reference to an
    attribute without first checking whether the attribute was
    defined.

Tests: Run /test/components/lz/test-basetabs.lzx. It should behave
    as expected, but without warning messages.


------------------------------------------------------------------------