History | Log In     View a printable version of the current page.  
   HOME       BROWSE PROJECT       FIND ISSUES   
    QUICK SEARCH:  
Issue Details (XML | Word | Printable)

Key: LPP-3994
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: -- --
Assignee: Mamye Kratt
Reporter: Geert Bevin
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo
LPP-3964

Javascript error : this.actAnim has no properties, this.actAnim[$2].stop()

Created: 18/May/07 12:47 AM   Updated: 16/Jul/07 03:49 PM
Component/s: Compiler - JavaScript
Affects Version/s: 4.0.2
Fix Version/s: Legals, 4.0.3

Time Tracking:
Not Specified

Environment: Firefox 2.0.0.3 MacOSX

Severity: Minor
Fixed in Change#: 5,556
Runtime: N/A
Fix in hand: False


 Description  « Hide
* log into blablalist
* create a list with 2 entries
* press the 'Edit' button in the top right menu
* Firebug shows this error:

this.actAnim has no properties
stop()LFCdhtml-debug.js (line 9787)
destroy()LFCdhtml-debug.js (line 9808)
destroy(true)LFCdhtml-debug.js (line 3599)
destroy(true)LFCdhtml-debug.js (line 8016)
destroy(true)LFCdhtml-debug.js (line 3599)
destroy(true)LFCdhtml-debug.js (line 8016)
destroy(true)LFCdhtml-debug.js (line 3599)
destroy(true)LFCdhtml-debug.js (line 8016)
destroy(undefined)LFCdhtml-debug.js (line 3599)
destroy(undefined)LFCdhtml-debug.js (line 8016)
destroyClone(LzView _instanceAttrs=Object _instanceChildren=[3])LFCdhtml-debug.js (line 13101)
construct(Datapath for LzView _instanceAttrs=Object __LZisnew=true parent=LzView , Object xpath=_ignoreAttribute ignoreplacement=true)LFCdhtml-debug.js (line 12936)
initialize(Datapath for LzView _instanceAttrs=Object __LZisnew=true parent=LzView , Object xpath=entry[@done='false'] ignoreplacement=true, undefined, undefined)LFCdhtml-debug.js (line 2984)
make()LFCdhtml-debug.js (line 2735)
__LZHandleMultiNodes([<entry id="42" name="testset" done="false" priority="0"/> nodeName=entry attributes=Object, <entry id="43" name="tests" done="false" priority="1"/> nodeName=entry attributes=Object])LFCdhtml-debug.js (line 12598)
runXPath()LFCdhtml-debug.js (line 11546)
__LZcheckChange(Object)LFCdhtml-debug.js (line 12080)
__LZcheckChange(Object)LFCdhtml-debug.js (line 12754)
sendEvent(Object)LFCdhtml-debug.js (line 4039)
__LZsendUpdate(undefined, undefined)LFCdhtml-debug.js (line 11636)
__LZsendUpdate(undefined, undefined)LFCdhtml-debug.js (line 12618)
__LZHandleSingleNode(<list authid="0bbe9d2bd4989e0026151c7789c6f441" id="37" name="Testing" shortname="testing" public="false" listurl="" feedurl="" printurl="/printablelist?id=37" privateshares="0" count="2" isowner="true"><description/><entry id="42" name="testset" done="false" priority="0"/><entry id="43" name="tests" done="false" priority="1"/></list> nodeName=list attributes=Object)LFCdhtml-debug.js (line 11583)
runXPath()LFCdhtml-debug.js (line 11549)
__LZcheckChange(Object who=LzDataset :getlistforedit_ds what=childNodes)LFCdhtml-debug.js (line 12080)
__LZcheckChange(Object who=LzDataset :getlistforedit_ds what=childNodes)LFCdhtml-debug.js (line 12754)
sendEvent(Object who=LzDataset :getlistforedit_ds what=childNodes)LFCdhtml-debug.js (line 4039)
handleDocumentChange("childNodes", LzDataset :getlistforedit_ds _instanceAttrs=Object __LZisnew=false, 0, undefined)LFCdhtml-debug.js (line 10927)
setChildNodes([<list authid="0bbe9d2bd4989e0026151c7789c6f441" id="37" name="Testing" shortname="testing" public="false" listurl="" feedurl="" printurl="/printablelist?id=37" privateshares="0" count="2" isowner="true"><description/><entry id="42" name="testset" done="false" priority="0"/><entry id="43" name="tests" done="false" priority="1"/></list> nodeName=list attributes=Object])LFCdhtml-debug.js (line 10855)
setData(<list authid="0bbe9d2bd4989e0026151c7789c6f441" id="37" name="Testing" shortname="testing" public="false" listurl="" feedurl="" printurl="/printablelist?id=37" privateshares="0" count="2" isowner="true"><description/><entry id="42" name="testset" done="false" priority="0"/><entry id="43" name="tests" done="false" priority="1"/></list> nodeName=list attributes=Object, _instanceAttrs=Object __LZisnew=true)LFCdhtml-debug.js (line 11225)
processRawData(LzDataset :getlistforedit_ds _instanceAttrs=Object __LZisnew=false, <list authid="0bbe9d2bd4989e0026151c7789c6f441" id="37" name="Testing" shortname="testing" public="false" listurl="" feedurl="" printurl="/printablelist?id=37" privateshares="0" count="2" isowner="true"><description/><entry id="42" name="testset" done="false" priority="0"/><entry id="43" name="tests" done="false" priority="1"/></list> nodeName=list attributes=Object)LFCdhtml-debug.js (line 13383)
gotRawData(<list authid="0bbe9d2bd4989e0026151c7789c6f441" id="37" name="Testing" shortname="testing" public="false" listurl="" feedurl="" printurl="/printablelist?id=37" privateshares="0" count="2" isowner="true"><description/><entry id="42" name="testset" done="false" priority="0"/><entry id="43" name="tests" done="false" priority="1"/></list> nodeName=list attributes=Object)LFCdhtml-debug.js (line 11217)
loadSuccess(Object dataset=LzDataset :getlistforedit_ds, <list authid="0bbe9d2bd4989e0026151c7789c6f441" id="37" name="Testing" shortname="testing" public="false" listurl="" feedurl="" printurl="/printablelist?id=37" privateshares="0" count="2" isowner="true"><description/><entry id="42" name="testset" done="false" priority="0"/><entry id="43" name="tests" done="false" priority="1"/></list> nodeName=list attributes=Object)LFCdhtml-debug.js (line 13227)
()LFCdhtml-debug.js (line 7631)
this.actAnim[$2_i].stop()


I don't use any stop() functions in my code. However, I think that there might a general problem of stop() not being supported in the DHTML engine. Maybe just make the function a no-op for static DHTML resources?

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
[ Permlink | « Hide ]
Philip Romanik - 25/May/07 03:05 PM
Summary: Fix: this.actAnim has no properties, this.actAnim[$2].stop()


New Features:

Bugs Fixed: LPP-3994

Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
In LzAnimatorGroup, it is possible that the internal variable actAnim can be nul
l and this condition was not checked in stop().

I also found an off-by-one type error in two places. This line of code,

 var animend = this.process == "simultaneous" ? this.actAnim.length -1 : 0;

is wrong if the animation is "sequential" and there are no animations (ie. this.
actAnim.length = 0). I re-wrote to make it clearer and to handle this case.


Tests:
blabla app runs in dhtml. See jira report. I added a comment to the parent bug (
LPP-3964) on how I debugged the app.

/test/smoke/smokecheck.lzx

/test/lztest/lztest-animator.lzx, /test/lztest/lztest-animatorgroup.lzx match in
 swf and dhtml.

lzpix


Files:
M WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070525-Philip-4.tar

[ Permlink | « Hide ]
Mamye Kratt - 28/Jun/07 11:21 AM
(4.0 branches (4.0.3) local build r5538)
/test/smoke/smokecheck.lzx
, /test/lztest/lztest-animator.lzx, /test/lztest/lztest-animatorgroup.lzx all have errors.

[ Permlink | « Hide ]
Mamye Kratt - 28/Jun/07 11:21 AM
Blocked

[ Permlink | « Hide ]
Mamye Kratt - 28/Jun/07 02:50 PM
(4.0 branch (4.0.3) local build r5544)

Both testfiles fail:
/test/lztest/lztest-animator.lzx
/test/lztest/lztest-animatorgroup.lzx

smokecheck reports success, but has many errors.

[ Permlink | « Hide ]
Philip Romanik - 29/Jun/07 10:41 AM
I checked in changes for the two unit tests. Some changes were missing because I forgot to check them in. I also changed all the known error cases to warnings.

[ Permlink | « Hide ]
Mamye Kratt - 16/Jul/07 03:49 PM
(4.0 branch (4.0.3) local build r5678)
/test/smoke/smokecheck.lzx (swf and dhtml)
/test/lztest/lztest-animator.lzx (swf and dhtml)
/test/lztest/lztest-animatorgroup.lzx (swf and dhtml)
lzpix (swf and dhtml)


Powered by a free Atlassian JIRA open source license for Open Laszlo. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.12-#298) - Bug/feature request - Contact Administrators