History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-3986
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: -- --
Assignee: Mamye Kratt
Reporter: Max Carlson
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

Move services/LzTrack.lzs to class system

Created: 16/May/07 10:34 AM   Updated: 16/Jul/07 04:06 PM
Component/s: Laszlo Foundation Classes (LFC)
Affects Version/s: 4.0.2
Fix Version/s: Legals, 4.0.3

Time Tracking:
Not Specified

Severity: Minor
Fixed in Change#: 5,298
Runtime: N/A
Fix in hand: False


 Description  « Hide
Right now, they use object syntax.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Philip Romanik - 02/Jun/07 06:45 AM
Change 20070529-Philip-6 by Philip@Philip-DC on 2007-05-29 14:15:49 EST
   in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
   for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Ported LzTrack.lzs to new class system

New Features:

Bugs Fixed: LPP-3986

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
Ported LzTrack.lzx to the new class system. LzTrack is a singleton class but is
written more like an ordinary class. To minimize the changes I made (and to make
 it 100% compatible with the old version), the class name is LzTrackClass. At th
e bottom of the file is:

   /** The single instance of this class
     * @access private
     */
   var LzTrack = new LzTrackClass;



Tests:
lzpix in swf and dhtml. The best test in this app is to drag an image into the clip region. When I first ported LzTrack the image disappeared when I released the mouse.

Run these in swf and dhtml:
http://localhost:8080/legals/test/lfc/lztrack/trackgroups.lzx
http://localhost:8080/legals/test/lfc/lztrack/trackgroup.lzx

Files:
M WEB-INF/lps/lfc/services/LzTrack.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070529-Philip-6.tar

Mamye Kratt - 03/Jul/07 04:58 PM
(4.0 branch (4.0.3) build r5585)

Tests have errors.

http://localhost:8080/legals/test/lfc/lztrack/trackgroup.lzx
swf
ERROR: trackgroup.lzx:13: call to undefined method 'write'

dhtml
ERROR: http://127.0.0.1:8080/4.0/test/lfc/lztrack/trackgroup.lzx?lzt=object&lzt=object&lzr=dhtml&_canvas_debug=true:98: Debug.evalCarefully("trackgroup.lzx", 13, (function () {return debug;}), this) has no properties

http://localhost:8080/legals/test/lfc/lztrack/trackgroups.lzx
swf
ERROR: trackgroups.lzx:46: reference to undefined variable 'debug'
ERROR: trackgroups.lzx:46: undefined object does not have a property 'write'
ERROR: trackgroups.lzx:68: reference to undefined variable 'debug'
ERROR: trackgroups.lzx:68: undefined object does not have a property 'write'
ERROR: trackgroups.lzx:11: reference to undefined variable 'debug'
ERROR: trackgroups.lzx:11: undefined object does not have a property 'write'
ERROR: trackgroups.lzx:77: reference to undefined variable 'debug'
ERROR: trackgroups.lzx:77: undefined object does not have a property 'write'

dhtml
ERROR: http://127.0.0.1:8080/4.0/test/lfc/lztrack/trackgroups.lzx?lzt=object&lzt=object&lzr=dhtml&_canvas_debug=true:2173: Debug.evalCarefully("trackgroups.lzx", 46, (function () {return debug;}), this) has no properties

Frisco Del Rosario - 05/Jul/07 05:12 PM
Everything's cool when Debug.write is capitalized.

Mamye Kratt - 16/Jul/07 04:06 PM
(4.0 branch (4.0.3) local build r5678)
lzpix (swf and dhtml) - clips works