[#LPP-3947] Flash and DHTM: Setting canvas width to 100% in legals results in a canvas that is 500 pixels wide

OpenLaszlo

Flash and DHTM: Setting canvas width to 100% in legals results in a canvas that is 500 pixels wide

Created: 04/May/07 04:47 PM Updated: 08/May/07 01:17 PM

Component/s:

Documentation

Affects Version/s:

4.0.2, Legals

Fix Version/s:

4.0.2, Legals

Time Tracking:

Not Specified

Severity:	Minor
Fixed in Change#:	4,194
Runtime:	N/A
Fix in hand:	False

Description

« Hide

(legals build 3903)

Henry Minsky wrote:
Has anyone noticed that setting canvas width to 100% in legals results in a canvas that
is 500 pixels wide? That is in firefox with swf7 on my windows machine. My browser width is more like 1200.

Max narrowed it down to the following bug and changeset in legals (works fine in 4511):
Documentation: Revision: 4515
Bugs Fixed:
~~LPP-3779~~ 'Misleading Compilation exception syntax error'

4.0 branch is broken after r4534 (integration from legals).

Risk: low -- numeric attribute values follow same compilation path as expressions now
Reward: User-reported bug

Test case:
<canvas width="75%" height="50%" bgcolor="0xe0e0e0">
  <simplelayout axis="y"/>
  <text name="msg" width="100%"/>

  <view width="100%" height="100%" bgcolor="0xa0a0a0">
    <text name="vmsg" width="100%"/>
    <method name="vmessage">
      vmsg.setText (parent.format(this.width, this.height));
    </method>
    <method event="oninit">vmessage();</method>
    <method event="onwidth">vmessage();</method>
    <method event="onheight">vmessage();</method>
  </view>

  <method name="format" args="w,h">
    return "Width: " + w + ", Height: " + h;
  </method>

  <method name="message">
    msg.setText (this.format (this.width, this.height));
  </method>
  <method event="oninit">message();</method>
  <method event="onwidth">message();</method>
  <method event="onheight">message();</method>
</canvas>

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Mamye Kratt - 04/May/07 04:48 PM

See comments in bug.

[ Permlink | « Hide ]

P T Withington - 05/May/07 08:23 PM

r4912 | ptw | 2007-05-05 23:21:48 -0400 (Sat, 05 May 2007) | 24 lines
Changed paths:
   M /openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java

Change 20070505-ptw-w by ptw@dueling-banjos.local on 2007-05-05 19:51:56 EDT
    in /Users/ptw/OpenLaszlo/legals-1
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Don't munge canvas.{height,width}

Bugs Fixed:
~~LPP-3947~~ 'Flash and DHTM: Setting canvas width to 100% in legals results in a canvas that is 500 pixels wide'

Technical Reviewer: max (Message-ID: <463D37B8.9070106@openlaszlo.org>)
QA Reviewer: mamye (pending)

Details:
    The canvas expects to be able to do all sorts of compile-time
    parsing and manipulation of its `width` and `height` properties,
    so we can't surround them with #beginAttribute #endAttribute
    directives that are used by the Parser to give better error
    messages for attributes.

Tests:
    Bug test case works correctly.
    ant lztest

[ Permlink | « Hide ]

P T Withington - 05/May/07 08:27 PM

Removing Osprey from affected versions, since it is not a branch yet.

[ Permlink | « Hide ]

P T Withington - 06/May/07 08:07 AM

r4914 | max | 2007-05-06 01:07:53 -0400 (Sun, 06 May 2007) | 30 lines
Changed paths:
   M /openlaszlo/branches/4.0
   M /openlaszlo/branches/4.0/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java

Merged revisions 4610-4623,4625-4651,4655-4659,4661-4664,4666-4672,4674-4681,4683-4692,4694-4699,4701-4713,4715-4716,4719-4732,4734-4738,4740-4741,4743-4744,4746-4747,4751-4753,4757-4758,4760-4762,4765,4768-4769,4771-4779,4781,4783,4785-4788,4791-4794,4796-4797,4799-4804,4808-4810,4812-4814,4816-4819,4822,4824-4832,4838-4841,4843-4844,4850-4853,4857,4859,4861-4865,4867,4871-4874,4877-4878,4880-4891,4894-4896,4899-4900,4902-4913 via svnmerge from
http://svn.openlaszlo.org/openlaszlo/branches/legals

........
  r4912 | ptw | 2007-05-05 20:21:48 -0700 (Sat, 05 May 2007) | 24 lines

  Change 20070505-ptw-w by ptw@dueling-banjos.local on 2007-05-05 19:51:56 EDT
      in /Users/ptw/OpenLaszlo/legals-1
      for http://svn.openlaszlo.org/openlaszlo/branches/legals

  Summary: Don't munge canvas.{height,width}

  Bugs Fixed:
  ~~LPP-3947~~ 'Flash and DHTM: Setting canvas width to 100% in legals results in a canvas that is 500 pixels wide'

  Technical Reviewer: max (Message-ID: <463D37B8.9070106@openlaszlo.org>)
  QA Reviewer: mamye (pending)

  Details:
      The canvas expects to be able to do all sorts of compile-time
      parsing and manipulation of its `width` and `height` properties,
      so we can't surround them with #beginAttribute #endAttribute
      directives that are used by the Parser to give better error
      messages for attributes.

  Tests:
      Bug test case works correctly.
      ant lztest
........

[ Permlink | « Hide ]

Mamye Kratt - 08/May/07 01:17 PM

(branches/4.0 build - 4915)
Fixed in dhtml and swf.