|
If you were logged in you would be able to see more operations.
|
|
|
OpenLaszlo
Created: 04/May/07 09:56 AM
Updated: 11/May/07 10:14 AM
|
|
| Component/s: |
Compiler
|
| Affects Version/s: |
3.4.1
|
| Fix Version/s: |
3.4.1
|
|
| Severity: |
Minor
|
| Fixed in Change#: |
4,964
|
| Runtime: |
N/A
|
| Fix in hand: |
False
|
|
On Wed, 2 May 2007, P T Withington wrote:
> With my latest change (4886), I get past the error where it was looking
> for an include that was not explicitly included (gorey details on
> request). Now I am getting an error on an include that _is_
> explicitly included, but is not built as a binary library.
> My methodology:
> cd client
> ant build-libraries
> cp -Rp future _package/lib
> cd _package/lib
> lzc future/lzmail/main.lzx
> Which yields:
> java.io.FileNotFoundException: ../contacts/components/ wtcombobox/
> library.lzx
> It appears that lzmail includes contacts, but contacts does not
> include wtcombobox, so lzmail includes wtcombobox directly, but
> that is not built by build-libraries.
> I don't know whether to put wtcombobox into contacts or to amend
> build-libraries.
> I am awaiting review from Henry on my change -- I'll let you know
> when it is in if you would like to test or tell me what to do
> with wtcombobox and I will see what the next issue is.
|
|
Description
|
On Wed, 2 May 2007, P T Withington wrote:
> With my latest change (4886), I get past the error where it was looking
> for an include that was not explicitly included (gorey details on
> request). Now I am getting an error on an include that _is_
> explicitly included, but is not built as a binary library.
> My methodology:
> cd client
> ant build-libraries
> cp -Rp future _package/lib
> cd _package/lib
> lzc future/lzmail/main.lzx
> Which yields:
> java.io.FileNotFoundException: ../contacts/components/ wtcombobox/
> library.lzx
> It appears that lzmail includes contacts, but contacts does not
> include wtcombobox, so lzmail includes wtcombobox directly, but
> that is not built by build-libraries.
> I don't know whether to put wtcombobox into contacts or to amend
> build-libraries.
> I am awaiting review from Henry on my change -- I'll let you know
> when it is in if you would like to test or tell me what to do
> with wtcombobox and I will see what the next issue is.
|
Show » |
|
Bug
Resolved
--
Can't compile a program that tries to explicitly include a sub-component of a binary library
Changed paths:
M /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/cm/CompilationManager.java
M /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/FileResolver.java
M /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/LibraryCompiler.java
M /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java
Change 20070509-ptw-0 by ptw@ebola on 2007-05-09 21:39:53 EDT
in /home/ptw/OpenLaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Handle explicit includes of binary library sub-components
Bugs Fixed:
LPP-3945"Can't compile a program that tries to explicitly include a sub-component of a binary library"Technical Reviewer: henry (Message-ID: <8c61fad60705101305k30b3141ena6178b398c608211@mail.gmail.com>)
QA Reviewer: pablo (pending)
Details:
CompilationManager: Support new getBinaryIncludes interface in
FileResolver.
LibraryCompiler: Note binary includes in FileResolver
FileResolver: Mantain a Set of binary includes and use that set to
'resolve' files that may not be in the binary distribution,
avoiding a non-existent file error.
Parser: Don't try to expand includes that are already implicitly
included by a binary file.
Tests:
lzc of lzmail using only binary libraries gets further now.