History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-3688
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: P1 P1
Assignee: Mamye Kratt
Reporter: P T Withington
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

New xml parsing not working?

Created: 12/Mar/07 04:03 PM   Updated: 08/May/07 01:44 PM
Component/s: LFC - Data
Affects Version/s: 3.4
Fix Version/s: 3.4.1, 4.0.2

Time Tracking:
Not Specified

File Attachments: 1. File datatext.lzx (0.3 kb)
2. XML File PFE550.xml (17 kb)
3. XML File PFE551.xml (17 kb)


Severity: Minor
Fixed in Change#: 4,765
Fixed in branch: trunk
Runtime: N/A
Fix in hand: False


 Description  « Hide
[Ming reports a regression with XML parsing in trunk (3.4). This error does not occur in 3.4.0.]

Date: Mon, 12 Mar 2007 14:33:34 -0700
From: Ming-en Cho <ming@laszlosystems.com>
Subject: [Platform-team] XML parsing changes?

Hi there-

Studios has started using 3.4.x and are noticing that the xml parser has
become a lot more finicky. When using static xml files sometimes the
dataset is not populated with any data but works perfectly fine in
3.3.3. I currently have a test case that shows the problem. There are
2 xml files included, one with 550 elements (pfe550.xml) and one with
551elements (pfe551.xml). pfe550.xml loads fine but the dataset using
pfe551.xml as its source remains empty. This bug is causing a problem
for our AJAX World demo apps so I'd appreciate it if you can get back to
me soon. Thanks!

Ming.


 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
P T Withington - 13/Mar/07 06:09 AM
Date: Mon, 12 Mar 2007 21:49:53 -0400
From: "Henry Minsky" <henry.minsky@gmail.com>
To: "P T Withington" <ptw@openlaszlo.org>
X-ASG-Orig-Subj: Re: [Platform-team] XML parsing changes?
Subject: Re: [Platform-team] XML parsing changes?
Cc: "Jim Grandy" <jgrandy@openlaszlo.org>,
        "Platform Team" <platform-team@laszlosystems.com>
In-Reply-To: <8c61fad60703121824k211195caq3320962a81f8353@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="----=_Part_4149_31370412.1173750593535"
References: <45F5C72E.3040506@laszlosystems.com>
<F8394410-F49C-498E-974E-E1DD92EC1884@openlaszlo.org>
<45F5E3CB.7000408@laszlosystems.com>
<8c61fad60703121642hb89f3b0s2d8ea5faad2cf376@mail.gmail.com>
<2FFA5870-9354-4602-AC61-BAF4A500E3A3@openlaszlo.org>
<8c61fad60703121824k211195caq3320962a81f8353@mail.gmail.com>
X-Barracuda-Virus-Scanned: by Barracuda Spam Firewall at laszlosystems.com
X-Synonym: Copied by Synonym (http://www.modulo.ro/synonym) to: mail-archive


------=_Part_4149_31370412.1173750593535
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=ISO-8859-1;
format=flowed
Content-Disposition: inline

So I guess we didn't back-port the fix to the compiler for long constant
strings to trunk after all ?


On 3/12/07, Henry Minsky <henry.minsky@gmail.com> wrote:
>
> I would suspect some 64k char limit on constant strings which is what the
> statically initialized XML compiles down to, but I thought we fixed that in
> the compiler.
>
>
> On 3/12/07, P T Withington <ptw@openlaszlo.org> wrote:
> >
> > Yeah, but that means we still got an issue in trunk (and probably
> > legal's). Since you and I ported the legal's implementation back to
> > trunk to support binary compiling.
> >
> > Filed as LPP-3688
> >
> > On 2007-03-12, at 19:42 EDT, Henry Minsky wrote:
> >
> > > Thank God.
> > >
> > >
> > >
> > >
> > > On 3/12/07, Ming-en Cho <ming@laszlosystems.com> wrote:
> > >>
> > >> http://svn.openlaszlo.org/openlaszlo/tags/3.4.0 solved the problem.
> > >> Thanks for the help!
> > >>
> > >> Ming.

Antun Karlovac - 18/Apr/07 04:11 PM
Was this ever fixed and validated in 4.0? The comments suggest it was not a problem in Legals, but I'm using 4.0 final, and I can't load large datasets. They just die. There's no error.

-Antun

P T Withington - 19/Apr/07 04:44 AM
Strange. It looks like Ming's test case works in DHTML in 4.0, but in SWF the _shorter_ dataset does not get built correctly.

This bug is not yet fixed for 3.4, where the _longer_ dataset does not get built correctly.

P T Withington - 19/Apr/07 04:48 AM
Henry: If I run Ming's test in SWF in profiterole, the shorter dataset shows up as having the content string in the 'trimwhitespace' slot?

Henry Minsky - 19/Apr/07 06:01 AM
, I will take a look


P T Withington - 19/Apr/07 11:27 AM
r4765 | ptw | 2007-04-19 12:24:13 -0400 (Thu, 19 Apr 2007) | 20 lines
Changed paths:
   M /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java

Change 20070419-ptw-K by ptw@dueling-banjos.local on 2007-04-19 11:03:35 EDT
    in /Users/ptw/OpenLaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Round-off error in string chunking

Bugs Fixed:
LPP-3688 'New xml parsing not working?'

Technical Reviewer: henry (verbal)
QA Reviewer: mayme (pending)
Doc Reviewer: n/a

Details:
    Round up chunk length

Tests:
    Test case from bug report

P T Withington - 19/Apr/07 11:28 AM
Also migrated to legals

r4766 | ptw | 2007-04-19 12:45:48 -0400 (Thu, 19 Apr 2007) | 14 lines
Changed paths:
   M /openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java

Change 20070419-ptw-9 by ptw@dueling-banjos.local on 2007-04-19 12:41:54 EDT
    in /Users/ptw/OpenLaszlo/legals-1
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Migrate 4765 to legals

Bugs Fixed:
LPP-3688 'New xml parsing not working?'

Technical Reviewer: henry (verbal)
QA Reviewer: mayme (pending)
Doc Reviewer: n/a