[#LPP-3579] Fix debugger in Safari

OpenLaszlo

Fix debugger in Safari

Created: 21/Feb/07 12:20 PM Updated: 13/Dec/07 05:54 PM

Component/s:

Debugger

Affects Version/s:

4.0.0, Legals

Fix Version/s:

Legals

Time Tracking:

Not Specified

Severity:	Minor
Fixed in Change#:	3,865
Runtime:	N/A
Release Note Text:	« Hide In lps.properties you can set compiler.debug.safari to true, do a clean build and flush your browser cache to allow debugging in Safari 2. This is not on by default because it makes debugging less useful in Firefox (backtaces will not see function names). WebKit and Safari 3 work correctly without any workaround. Show » In lps.properties you can set compiler.debug.safari to true, do a clean build and flush your browser cache to allow debugging in Safari 2. This is not on by default because it makes debugging less useful in Firefox (backtaces will not see function names). WebKit and Safari 3 work correctly without any workaround.
Fix in hand:	False

Description

« Hide

I'm blocked on this - I have 3 p1s that I can't debug in safari, and my unit tests won't run.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

P T Withington - 21/Feb/07 02:38 PM

r3865 | ptw | 2007-02-21 14:36:37 -0800 (Wed, 21 Feb 2007) | 29 lines
Changed paths:
   M /openlaszlo/branches/legals/WEB-INF/lps/config/lps.properties
   M /openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
   M /openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java

Change 20070221-ptw-T by ptw@dueling-banjos.local on 2007-02-21 13:00:06 PST
    in /Users/ptw/OpenLaszlo/legals-1

Summary: Allow debugging in Safari 2

Bugs Fixed:
~~LPP-3579~~: 'Fix debugger in Safari'

Technical Reviewer: max (Message-ID: <45DCC64F.9090105@openlaszlo.org>)
QA Reviewer: hminsky (pending)
Doc Reviewer: jsundman (pending)

Documentation:

In lps.properties you can set compiler.debug.safari to true to allow
debugging in Safari. This is not on by default because it makes
debugging less useful in Firefox (backtaces will not see function
names).

Details:
    lps.properties: Document option

    Compiler: Look for compiler.debug.safari property

    JavascriptGenerator: Don't name function expressions if that flag
    is on.

Tests:
    IWFMax

[ Permlink | « Hide ]

P T Withington - 21/Feb/07 02:39 PM

If you uncomment this line in WEB-INF/lps/config/lps.properties

#compiler.debug.safari=true

and do a clean build, smokecheck will run in Safari

[ Permlink | « Hide ]

Benjamin Shine - 06/Jul/07 04:20 PM

This is happening again. Observed in Safari 2.0.4, legals build 5588, Mac OS X 10.4.10

[ Permlink | « Hide ]

Jim Grandy - 06/Jul/07 04:22 PM

Possibly a result of r5579?

[ Permlink | « Hide ]

P T Withington - 07/Jul/07 10:51 AM

Are you seeing it even after you set compiler.debug.safari to true in lps.properties (and do a clean recompile)?

Note that the default build is not debuggable in Safari 2, due to a bug in the Safari Javascript parser. There is a work-around (settting that property and recompiling), but we don't leave it on by default because a) it makes debugging in Firebug _much_less_ useful, and b) the bug is fixed in Safari 3.

[ Permlink | « Hide ]

P T Withington - 17/Jul/07 01:03 PM

WebKit and Safari 3 work correctly. The release notes describe a work-around if you must debug under Safari 2.