[#LPP-2762] Debugger in DHTML no longer warns about undefined variable references

OpenLaszlo

Debugger in DHTML no longer warns about undefined variable references

Created: 25/Sep/06 05:32 PM Updated: 27/Sep/07 08:55 AM

Component/s:

Kernel

Affects Version/s:

4.0.0

Fix Version/s:

RingDing (4.1)

Time Tracking:

Not Specified

Severity:	Minor
Fixed in Change#:	4,602
Runtime:	N/A
Fix in hand:	False

Description

« Hide

<canvas width="1000" height="600" debug="true">
<button onclick="Debug.write(foobar)">Click Me</button>
</canvas>

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

P T Withington - 03/Apr/07 09:42 AM

This shows that the error is being caught, but somehow the message is not making it to the console. After clicking:

lzx> Debug.sourceWarningHistory
[]
lzx> Debug.inspect([])
«Array(0)#1| []» {
WARNING: lpp-2762.lzx:2: ReferenceError: foobar is not defined
: true
}
[]
lzx>

[ Permlink | « Hide ]

P T Withington - 08/May/07 08:15 PM

r4602 | ptw | 2007-04-06 20:34:06 -0400 (Fri, 06 Apr 2007) | 39 lines
Changed paths:
   M /openlaszlo/branches/legals/WEB-INF/lps/lfc/compiler/LzRuntime.lzs
   M /openlaszlo/branches/legals/WEB-INF/lps/lfc/debugger/LzMessage.lzs
   M /openlaszlo/branches/legals/WEB-INF/lps/lfc/debugger/platform/dhtml/kernel.js

Change 20070403-ptw-s by ptw@dueling-banjos.local on 2007-04-03 17:02:03 EDT
    in /Users/ptw/OpenLaszlo/legals-1
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Hook Debug.log to Firebug

Bugs Fixed:
~~LPP-2762~~ 'Debugger in DHTML no longer warns about undefined variable references'

Technical Reviewer: max (verbal)
QA Reviewer: henry (verbal)
Doc Reviewer: jsundman (pending)

Documentation:
If you have Firebug installed in your browser, `_dbg_log_all__writes`
will default to `true` and all debugging output will be logged to the
Firebug console.

This can be useful for debugging errors in the debugger or errors that
occur early in the start-up of the LFC before the debugger output is
fully functional.

Details:
    LzMessage: Fix constructor so that it does not store random
    objects in the message slot (e.g., $reportSourceWarning passes the
    error object as an initial value). This fixes ~~LPP-2762~~.

    To debug ~~LPP-2762~~:

    Add LzMessage.toArray and LzSourceMessage.toArray which convert
    message objects into arrays of strings and objects for passing to
    console log (so objects are inspectable).

    kernel.js, LzRuntime: Implement Debug.log by hooking it to Firebug (if it exists).

Tests:
    IWFM, Test case from bug passes

[ Permlink | « Hide ]

P T Withington - 08/May/07 08:21 PM

r4684 | max | 2007-04-11 23:13:30 -0400 (Wed, 11 Apr 2007) | 43 lines
Changed paths:
   M /openlaszlo/branches/4.0/WEB-INF/lps/lfc/compiler/LzRuntime.lzs
   M /openlaszlo/branches/4.0/WEB-INF/lps/lfc/debugger/LzMessage.lzs
   M /openlaszlo/branches/4.0/WEB-INF/lps/lfc/debugger/platform/dhtml/kernel.js

Change 20070411-maxcarlson-O by maxcarlson@plastik on 2007-04-11 14:46:48 PDT
    in /Users/maxcarlson/openlaszlo/4.0
    for http://svn.openlaszlo.org/openlaszlo/branches/4.0

Summary: Integrate debugger changes from legals to 4.0.1

New Features:

Bugs Fixed:

Technical Reviewer: promanik
QA Reviewer: ptw
Doc Reviewer: (pending)

Documentation: Needed to merge over 4602 and 4682.

This needs to be migrated to 4.0.1

Risk: none
Reward: lztest will pass

Release Notes:

Details:
plastik:~/openlaszlo/4.0 maxcarlson$ svn merge -r4601:4602 http://svn.openlaszl
o.org/openlaszlo/branches/legals/
U WEB-INF/lps/lfc/debugger/LzMessage.lzs
U WEB-INF/lps/lfc/debugger/platform/dhtml/kernel.js
U WEB-INF/lps/lfc/compiler/LzRuntime.lzs
plastik:~/openlaszlo/4.0 maxcarlson$ svn merge -r4681:4682 http://svn.openlaszl
o.org/openlaszlo/branches/legals/
G WEB-INF/lps/lfc/compiler/LzRuntime.lzs

Tests: ant clean build lztest passes.

Files:
M WEB-INF/lps/lfc/debugger/LzMessage.lzs
M WEB-INF/lps/lfc/debugger/platform/dhtml/kernel.js
M WEB-INF/lps/lfc/compiler/LzRuntime.lzs