History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-2574
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: P2 P2
Assignee: Frisco Del Rosario
Reporter: Elliot Winard
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

Charting components don't allow easy extension - datacolumn can not be easily extended, for instance

Created: 28/Aug/06 03:58 PM   Updated: 24/Nov/06 01:20 PM
Component/s: Components - Charting and Graphing
Affects Version/s: None
Fix Version/s: 3.4, 3.3.3

Time Tracking:
Not Specified

Severity: Major
Runtime: N/A
Fix in hand: True


 Description  « Hide
I'm trying to extend datacolumn to work around bug 2652 - There is no way to create certain charts when XML driving charts has certain structure - and my extension will *not* work because of the way dataseries is implemented.

I created a "newdatacolumn" class that allowed datacolumn's values to be set by passing in a function that returns an array of children rather than an xpath. My new datacolumn will not work inside a dataseries because of the way dataseries checks for class -
                if((this.subnodes[i].classname == "datacolumn") && (this.subnodes[i].name == name))

This type of check happens in a few places in the charting code.

What it *should* do is use instanceof for class checks. This would enable users to extend charting classes. i.e. -
               if((this.subnodes[i] instanceof datacolumn) && (this.subnodes[i].name == name))
 

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Josh Crowley - 24/Nov/06 01:20 PM
Approved by Max.