History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-227
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: P1 P1
Assignee: Mark Davis
Reporter: Amy Muntz
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

Fix source location bug "missing some sourceLocations"

Created: 08/Apr/05 08:48 AM   Updated: 26/Jun/06 09:35 PM  Due: 15/Apr/05
Component/s: None
Affects Version/s: None
Fix Version/s: Rucker

Time Tracking:
Original Estimate: Not Specified
Remaining Estimate: 0 minutes
Time Spent - 6 hours
Time Spent: 6 hours
Time Spent - 6 hours

Severity: Critical
Runtime: N/A


 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
P T Withington - 13/Apr/05 01:03 PM
Ok, well something seems to be filtering the attributes that get to the window. If I look at the script output, I see the source locator attribute is definitely there in the script, but when I look at the object's _instanceAttrs, which should be initialized from that same object, the source locator is gone. I did the simple experiment of trying a different name for the source locator, but no dice.

Is it possible that some nifty schema feature is eliding the source locator attribute?

P T Withington - 15/Apr/05 08:19 AM
The guilty party is embed.js which enforces a 'whitelist' on query parameters. It is not passing the sourcelocators parameter. As a work-around, you can fetch with ?lzt=html-object. I am testing a fix to embed.js.

P T Withington - 15/Apr/05 09:18 AM
Change 26029 by ptw@ptw-rucker on 2005/04/15 09:00:33 *pending*

Summary: make source locators work again

Bugs Fixed:
Bug: LPP-227 'Fix source location bug "missing some
sourceLocations"'

Technical Reviewer: osteele (pending)
QA Reviewer: mdavis (pending)
Doc Reviewer: n/a

Details: embed.js: add 'sourcelocators' to embed.js query
parameter whitelist.

Tests: added test case, loaded test case (after clearing my
Safari cache) and observed that childWindow.__LZsourceLocation
was not null.

Affected files ...

... //depot/lps-rucker/WEB-INF/lps/server/bin/lzc#1 edit
... //depot/lps-rucker/lps/includes/embed.js#1 edit
... //depot/lps-rucker/test/bugs/lpp-227.lzx#1 add


P T Withington - 15/Apr/05 10:11 AM
Change 26029 submitted.