History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-2001
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: P1 P1
Assignee: Mamye Kratt
Reporter: Amy Muntz
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

Apply piepiece.lzx patch from contributor

Created: 26/Apr/06 10:34 AM   Updated: 26/Jun/06 09:38 PM
Component/s: Components - Charting and Graphing
Affects Version/s: 3.3
Fix Version/s: 3.3, 3.3.3

Time Tracking:
Not Specified

File Attachments: 1. Zip Archive piechart.zip (4 kb)


Severity: Major
Fixed in Change#: 42,042
Runtime: N/A
Release Note Text: Piechart patch contributed by Sebastian Barthelmess.
Fix in hand: True


 Description  « Hide
Piechart.zip file contributed by Sebastian Barthelmess. Reviewed by component owner GSmedley. Review below.


I compared the files to the 3.2 release and found a few different fixes
in the patch.

1. Two changes to the gradient drawing calls in piepiece.lzx:
                addColorStop(0, '0xffffff');
changed to:
                addColorStop(0, 0xffffff);

This looks right since addColorStop() is supposed to take a number as
the second parameter. This will lighten up charts that use the default
gradients, but this probably won't be a problem since the default's
appeal is limited. This fix should also be made in datamarker.lzx line 82.

2. Changes to skip drawing wedges that are too small. in
renderOutlineWedge();

I made a test and was able to produce a chart with wedges that shot
across the canvas. Applying these changes fixes that, however it can
leave adjacent wedges with the same colour, so I believe it would be
better to detect small wedges at a higher level where colour adjustments
can be made. Might be OK as a temporary patch.

3. Changes to deal with changing datasets in piechart.lzx

Applying this change made the test charts stop drawing altogether
because it doesn't allow for charts with static datasets. This would
need more thought before being applied.




 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Amy Muntz - 26/Apr/06 10:36 AM
Jim - please integrate into both lps-dev and 3.2.1. Thanks!

Jim Grandy - 27/Apr/06 01:24 PM
Garth's comment indicates that the changes to piechart.lzx do not work. We need to decide whether to send the whole change back to Sebastian or take just the change to piepiece.lzx.

Amy Muntz - 03/May/06 10:47 AM
Only take the piece that works - as indicated in Garth's review.
Sebastian was aware that the rest was a 'hack' in his words.

Jim Grandy - 04/May/06 07:55 PM
Integrated to lps-3.2 as change 42043

Mamye Kratt - 12/May/06 02:38 PM
Comment in bug states: This fix should also be made in datamarker.lzx line 82.
datamarker.lzx still contains mygradient.addColorStop(0, '0xffffff');

Jim Grandy - 12/May/06 04:32 PM
Updated merge in 42232 (lps-dev) and 42233 (lps-3.2)

Mamye Kratt - 16/May/06 03:37 PM
Verified and closed on 05/16/06 for 3.2.1 release.